Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 test(VSecM): unit tests added for core/audit and core/constants #1099

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

gurkanguray
Copy link
Contributor

Unit tests for core packages

Description

Unit tests are developed for the core/constants and core/audits. The aim is having 100% coverage ratio for the packages

Changes

Test files added for core/constants and core/audits packages.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

Unit tests are developed for the core/constants and core/audits. The aim is having 100% coverage ratio for the packages

Signed-off-by: Guray Gurkan <guraygrkn@gmail.com>
@vmwclabot
Copy link

@gurkanguray, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@v0lkan
Copy link
Contributor

v0lkan commented Aug 26, 2024

Thanks for your contribution @gurkanguray 🙏 .

I can merge this after you sign off the commit.

@vmwclabot
Copy link

@gurkanguray, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@gurkanguray
Copy link
Contributor Author

@v0lkan I signed off the commit 🙏

@v0lkan v0lkan merged commit 5be4183 into vmware-tanzu:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants