ipv6 support for the aggregator handler. #542
Labels
Comments
|
/assign @liztio |
|
to test this you can use kubeadm-dind like: cleanup is |
mauilion
changed the title
|
pretty sure the bug is here: path.host needs to be split into path.hostname and path.port and hostname needs wrapped in [ ] if it's an ip. |
|
@liztio this seems like an easy patch to the client/dialer code, could you enqueue this one for this week? |
mauilion
changed the title
|
I'm wrong actually the baseurl needs to be bracketed before passing to the handler |
mauilion
pushed a commit
to mauilion/sonobuoy
that referenced
this issue
Oct 16, 2018
This change adds brackets around the ip address when it is learned. This is compatible with ipv4 and ipv6 setups. Before this change if you ran sonobuoy in an ipv6 cluster the aggregation mechanism would break with logs like: ``` 13:10 $ sonobuoy e2e ipv4_with_ipv6_fix.tar.gz --show passed passed tests [k8s.io] Pods should be submitted and removed [NodeConformance] [Conformance] ``` preventing the sonbuoy pod from marking any plugin complete. After this change the url passed to the aggregator handler will have the ip address bracketed. This was tested with kubeadm-dind in both ipv4 and ipv6 configurations. An example sonobuoy container with this fix is located here: quay.io/mauilion/sonobuoy:ipv6_fix You can test this locally with: ``` wget https://cdn.rawgit.com/kubernetes-sigs/kubeadm-dind-cluster/master/fixed/dind-cluster-v1.11.sh $ chmod +x dind-cluster-v1.11.sh $ export IP_MODE=ipv6 $ ./dind-cluster-v1.11.sh up $ sonobuoy run -m Quick --sonobuoy-image=quay.io/mauilion/sonobuoy:ipv6_fix ``` Signed-off-by: Duffie Cooley <dcooley@heptio.com>
timothysc
pushed a commit
that referenced
this issue
Oct 16, 2018
This change adds brackets around the ip address when it is learned. This is compatible with ipv4 and ipv6 setups. Before this change if you ran sonobuoy in an ipv6 cluster the aggregation mechanism would break with logs like: ``` 13:10 $ sonobuoy e2e ipv4_with_ipv6_fix.tar.gz --show passed passed tests [k8s.io] Pods should be submitted and removed [NodeConformance] [Conformance] ``` preventing the sonbuoy pod from marking any plugin complete. After this change the url passed to the aggregator handler will have the ip address bracketed. This was tested with kubeadm-dind in both ipv4 and ipv6 configurations. An example sonobuoy container with this fix is located here: quay.io/mauilion/sonobuoy:ipv6_fix You can test this locally with: ``` wget https://cdn.rawgit.com/kubernetes-sigs/kubeadm-dind-cluster/master/fixed/dind-cluster-v1.11.sh $ chmod +x dind-cluster-v1.11.sh $ export IP_MODE=ipv6 $ ./dind-cluster-v1.11.sh up $ sonobuoy run -m Quick --sonobuoy-image=quay.io/mauilion/sonobuoy:ipv6_fix ``` Signed-off-by: Duffie Cooley <dcooley@heptio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps did you take and what happened:
When running sonobuoy on a pure ipv6 cluster the systemd plugin doesn't work correctly we see errors like:
where fd00:40::3:0:0:3 not in brackets like https://[fd00:40::3:0:0:3]:8080.
Keeping the call from working.
What did you expect to happen:
That the code would bracket all ips so that this works. You can bracket ipv4 or ipv6 addresses and things work well.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
kubectl version):/etc/os-release):The text was updated successfully, but these errors were encountered: