Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [It] prefix for E2E_FOCUS #1934

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

tumberino
Copy link
Contributor

What this PR does / why we need it:
Currently the --rerun-failed flag doesn't work with the [It] prefix included in the test name. Related onsi/ginkgo#1277.

We need to strip the [It] prefix before using it the names in E2E_FOCUS.

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

Fixes `--rerun-failed` flag for `sonobuoy run` command.

Currently the `--rerun-failed` flag doesn't work with the `[It]` prefix
included in the test name

Fixes: vmware-tanzu#1925

Signed-off-by: James Tumber <james.tumber@ibm.com>
Copy link

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@franknstyle franknstyle merged commit eb5ac8a into vmware-tanzu:main Oct 18, 2023
19 checks passed
@tumberino tumberino deleted the strip-it-prefix branch October 19, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lost the ability to read "[It]" tags for E2E_FOCUS variable
3 participants