Retry results #730
Merged
Retry results #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=========================================
Coverage ? 40.47%
=========================================
Files ? 69
Lines ? 3943
Branches ? 0
=========================================
Hits ? 1596
Misses ? 2248
Partials ? 99
Continue to review full report at Codecov.
|
stevesloka
reviewed
Jun 4, 2019
In the case where a connection gets reset or other processing errors occur, the client is already coded to automatically retry submission of the results. However, the server was marking the results as 'seen' and would not reprocess them. This change allows reprocessing results only if there were errors processing before. Fixes #728 Signed-off-by: John Schnake <jschnake@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be rebased/tweaked after #729 merges which simplifies this update/testing since it puts all the logic in one place.
What this PR does / why we need it:
In the case where a connection gets reset or other
processing errors occur, the client is already
coded to automatically retry submission of the
results.
However, the server was marking the results as 'seen'
and would not reprocess them.
This change allows reprocessing results only if there
were errors processing before.
Which issue(s) this PR fixes
Fixes #728
Special notes for your reviewer:
FWIW, with the centralized code I think some other tests could be fixed up and made to read a bit better but it's not really worth it to go and rework older tests.
Release note: