Update cosign and k8s.io/* dependencies
#757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cosign: `v2.0.3-0.20230519173114-f21081a18209` -> `v2.2.4` - k8s.io/* : `v0.26.3` -> `v0.28.3`
Reference: https://github.com/darccio/mergo/blob/v0.3.16/merge.go#L342 It looks like when we pass `mergo.WithOverwriteWithEmptyValue` the merge overwrites the values in destination config based on input from source config. If we remove that option, the merge works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Dependency Updates:
cosign/v2:v2.0.3-0.20230519173114-f21081a18209->v2.2.4k8s.io/*:v0.26.3->v0.28.3Removes dependency of the
github.com/vmware-tanzu/tanzu-framework/capabilities/clientpackage by coping the necessary bits to this repository. (This is required because the above package is not maintained anymore.Pass the HTTP client to the
NewDynamicRESTMapperAPI as theapiutil.WithLazyDiscoveryhas been removed.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer