Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Support shell completion for fish shell and powershell #3158

Closed
marckhouzam opened this issue Aug 18, 2022 · 0 comments · Fixed by #3550
Closed

Support shell completion for fish shell and powershell #3158

marckhouzam opened this issue Aug 18, 2022 · 0 comments · Fixed by #3550
Labels
area/cli area/core-cli area/plugin area/ux UX related kind/feature Categorizes issue or PR as related to a new feature

Comments

@marckhouzam
Copy link
Contributor

Describe the feature request

The tanzu CLI should support shell completion for the fish shell and for powershell.
All plugins currently support both these shells for completion when run directly; but when run through the tanzu CLI, those shells are not supported.

The completion logic is 100% handled by Cobra and all we need to do in the CLI is to hook into it.

Affected product area (please put an X in all that apply)

  • (x) CLI
  • (x) Plugin
  • (x) User Experience
  • (x) Developer Experience

Additional context

@marckhouzam marckhouzam added kind/feature Categorizes issue or PR as related to a new feature needs-triage Indicates an issue or PR needs to be triaged labels Aug 18, 2022
@maralavi maralavi added area/cli area/plugin area/ux UX related and removed needs-triage Indicates an issue or PR needs to be triaged labels Aug 19, 2022
marckhouzam added a commit to marckhouzam/tanzu-framework that referenced this issue Oct 4, 2022
Fixes vmware-tanzu#3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
marckhouzam added a commit to marckhouzam/tanzu-framework that referenced this issue Oct 5, 2022
Fixes vmware-tanzu#3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
marckhouzam added a commit to marckhouzam/tanzu-framework that referenced this issue Oct 12, 2022
Fixes vmware-tanzu#3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
marckhouzam added a commit to marckhouzam/tanzu-framework that referenced this issue Oct 25, 2022
Fixes vmware-tanzu#3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
vuil pushed a commit that referenced this issue Oct 25, 2022
Fixes #3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
m1zzx2 pushed a commit that referenced this issue Oct 31, 2022
Fixes #3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
m1zzx2 pushed a commit that referenced this issue Oct 31, 2022
Fixes #3158

Note also that with Cobra 1.5, it is no longer necessary
to have zsh >= 5.2 (see spf13/cobra#1665)

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli area/core-cli area/plugin area/ux UX related kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants