Generate Package Custom Resource when Package Bundle is Created

[codegold79]

What this PR does / why we need it

This PR makes changes to package tooling to also generate Package CR when the package bundle is being created.

Merge this PR after PR #2187 (generate thick tarball)

Which issue(s) this PR fixes

Fixes #2158

Describe testing done for PR

make local-registry
PACKAGE_NAME=featuregates PACKAGE_REPOSITORY=management OCI_REGISTRY=${OCI_REGISTRY} make package-bundle

PACKAGE_REPOSITORY=standalone OCI_REGISTRY=${OCI_REGISTRY} make package-bundles

PACKAGE_SUB_VERSION=vmw.8-0 PACKAGE_NAME=featuregates PACKAGE_REPOSITORY=management make package-bundle     

Release note

Package tooling generates Package CR when package bundle is being created

PR Checklist

• Squash the commits into one or a small number of logical commits
  
• Use good commit messages
• Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

[codegold79]

@danniel1205 was worried about images: null showing up in his playground example:

I can provide the assurance that in our code, images is not null. You can see for yourself when you run the following ytt command in the project root:

$ ytt -f hack/packages/templates/repo-utils/images-tmpl.yaml -f hack/packages/templates/repo-utils/package-helpers.lib.yaml -f packages/package-values.yaml -v packageRepository=management -v registry=dockerhub.frankie
apiVersion: imgpkg.carvel.dev/v1alpha1
images:
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/featuregates:vlatest
  image: dockerhub.frankie/featuregates@sha256:featuregates:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/cliplugins:vlatest
  image: dockerhub.frankie/cliplugins@sha256:cliplugins:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/core-management-plugins:vlatest
  image: dockerhub.frankie/core-management-plugins@sha256:core-management-plugins:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/addons-manager-v2:vlatest
  image: dockerhub.frankie/addons-manager-v2@sha256:addons-manager-v2:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkg:vlatest
  image: dockerhub.frankie/tkg@sha256:tkg:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkg-clusterclass:vlatest
  image: dockerhub.frankie/tkg-clusterclass@sha256:tkg-clusterclass:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkg-clusterclass-docker:vlatest
  image: dockerhub.frankie/tkg-clusterclass-docker@sha256:tkg-clusterclass-docker:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkg-clusterclass-azure:vlatest
  image: dockerhub.frankie/tkg-clusterclass-azure@sha256:tkg-clusterclass-azure:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkg-clusterclass-vsphere:vlatest
  image: dockerhub.frankie/tkg-clusterclass-vsphere@sha256:tkg-clusterclass-vsphere:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkg-clusterclass-aws:vlatest
  image: dockerhub.frankie/tkg-clusterclass-aws@sha256:tkg-clusterclass-aws:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkr-aws-machine-webhook:vlatest
  image: dockerhub.frankie/tkr-aws-machine-webhook@sha256:tkr-aws-machine-webhook:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkr-azure-machine-webhook:vlatest
  image: dockerhub.frankie/tkr-azure-machine-webhook@sha256:tkr-azure-machine-webhook:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkr-docker-machine-webhook:vlatest
  image: dockerhub.frankie/tkr-docker-machine-webhook@sha256:tkr-docker-machine-webhook:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkr-vsphere-machine-webhook:vlatest
  image: dockerhub.frankie/tkr-vsphere-machine-webhook@sha256:tkr-vsphere-machine-webhook:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/tkr-service:vlatest
  image: dockerhub.frankie/tkr-service@sha256:tkr-service:latest
- annotations:
    kbld.carvel.dev/id: dockerhub.frankie/framework:vlatest
  image: dockerhub.frankie/framework@sha256:framework:latest
kind: ImagesLock

The difference between Daniel's example and our code are several.

For one, in @danniel1205 's playgound, he has the following in the first line of the data-values.yml file:

#@data/values-schema

That line needs to be changed to what it is in packages/package-values.yaml#L1.

#@data/values

Having values-schema forces the images attribute to be a default empty array.

Another difference is that Daniel is missing the array items the contain annotations and image sections. These are available in our code in the images-tmpl.yaml file. Given those, the images attribute will be populated with array items that contain annotations and images.

I am also just learning about YTT and what all it can do. I'm still not certain how it all works, but I'm learning that even the first line, whether it is values-schema or values makes a big difference.

[danniel1205]

LGTM

[yharish991]

LGTM