Bump sigs.k8s.io/controller-tools from 0.8.0 to 0.9.2 in /hack/tools #2795

dependabot · 2022-06-30T14:20:45Z

Bumps sigs.k8s.io/controller-tools from 0.8.0 to 0.9.2.

Release notes

Sourced from sigs.k8s.io/controller-tools's releases.

v0.9.2

changes since v0.9.1

🐛 Bug Fixes

Fix crd flattening for structType marker to not create duplicate entries for XMapType (#698)

Thanks to all our contributors!

v0.9.1

changes since v0.9.0

✨ New Features

Make topology markers also valid for type definitions (#693)

🐛 Bug Fixes

crd/gen: sort FindKubeKinds (#694)

crdgen: compare metav1 pkg by ID (#686)

🌱 Others

Simplify the LoadRootsWithConfig logic #695

Thanks to all our contributors!

v0.9.0

changes since v0.8.0

✨ New Features

: deepcopy: gen: match Go 1.17 build tag format (#595)

Bump k8s to 1.24.0 (#669)

Cross-module support for filesystem paths (#663)

Bump to k8s.io v1.24.0-rc.1 (#666)

Add XValidation CRD marker for KEP-2876 support. (#653)

🐛 Bug Fixes

Allow floating-point values in validations (#619)

Fixed panic when parsing selector expressions containing composite literals (#648)

CRD generation: remove status before writing (#630)

Thanks to all our contributors!

Commits

0c985d9 Merge pull request #698 from chrischdi/pr-fix-XMapTypeFlatten-cp-0.9
f50232a Fix crd flattening for XMapType to not duplicate entries
c8fc4d4 Merge pull request #695 from k8s-infra-cherrypick-robot/cherry-pick-687-to-re...
7c994fc ✨ crd/gen: sort FindKubeKinds (#694)
cd25c0b Simplify the LoadRootsWithConfig logic
8d80422 Merge pull request #693 from k8s-infra-cherrypick-robot/cherry-pick-692-to-re...
3fe0a0c Make topology markers also valid for type definitions
3c8b410 🐛 crdgen: compare metav1 pkg by ID (#686)
a260f13 Merge pull request #595 from benpbrown/ben-2c9e4
25549bf Merge pull request #669 from xrstf/bump-k8s
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

codecov · 2022-07-26T19:43:53Z

Codecov Report

Merging #2795 (62f46c7) into main (550bdd6) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 62f46c7 differs from pull request most recent head ce59d21. Consider uploading reports for the commit ce59d21 to get more accurate results

@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
- Coverage   44.22%   44.12%   -0.11%     
==========================================
  Files         416      416              
  Lines       42143    42113      -30     
==========================================
- Hits        18638    18582      -56     
- Misses      21782    21805      +23     
- Partials     1723     1726       +3

Impacted Files	Coverage Δ
...ntroller/tkr-status/clusterstatus/clusterstatus.go	`42.14% <0.00%> (-9.08%)`	⬇️
.../v1/sdk/capabilities/discovery/tkg/capabilities.go	`70.45% <0.00%> (-5.64%)`	⬇️
pkg/v1/tkg/client/upgrade_cluster.go	`40.00% <0.00%> (-2.58%)`	⬇️
pkg/v1/tkg/client/machine_deployment_cc.go	`71.16% <0.00%> (-0.11%)`	⬇️
pkg/v1/tkg/tkgconfighelper/validate.go	`81.81% <0.00%> (ø)`
pkg/v1/sdk/capabilities/discovery/tkg/fake.go	`57.14% <0.00%> (ø)`
pkg/v1/tkg/client/cluster.go	`14.45% <0.00%> (+0.02%)`	⬆️
pkg/v2/tkr/util/version/version.go	`89.28% <0.00%> (+2.07%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

yharish991

LGTM!! Can you add a release note?

rajathagasthya · 2022-08-01T16:28:59Z

Why does this require a release note? We usually only have them for user facing changes.

vijaykatam · 2022-08-01T17:03:05Z

config/crd/bases/cni.tanzu.vmware.com_antreaconfigs.yaml

@@ -153,6 +153,18 @@ spec:
                            description: Flag to enable/disable service external IP
                            type: boolean
                        type: object
+                      flowExporter:


Were the CRD's out of sync? cc @knabben

Yep, it was.

vijaykatam · 2022-08-01T17:04:51Z

config/crd/bases/cpi.tanzu.vmware.com_vspherecpiconfigs.yaml

@@ -106,6 +106,7 @@ spec:
                        - kind
                        - name
                        type: object
+                        x-kubernetes-map-type: atomic


how does k8s api-machinery ensure that there are no concurrent modifications for map object?

I think this is less to do with concurrent modifications and more to do with "merging" fields using server-side apply. atomic means you are replacing the whole map instead of specific fields.

Concurrency control is always enforced using resourceVersion comparison.

I see, thanks for the info. Looks like atomic will restrict other managers from updating fields. If the current default behavior is granular I think we should keep that.

Default is granular, but these fields are specifically inheriting atomic from corev1 structs they refer to.

tanzu-framework/apis/cpi/v1alpha1/vspherecpiconfig_types.go

Line 115 in 5c69b9e

VSphereCredentialLocalObjRef *v1.TypedLocalObjectReference `json:"vSphereCredentialLocalObjRef,omitempty"`

https://github.com/kubernetes/api/blob/f5e1938afa507ee250e4a0a7a45cd2498e3750d3/core/v1/types.go#L5690-L5714

vijaykatam · 2022-08-01T17:05:06Z

config/crd/bases/cli.tanzu.vmware.com_catalogs.yaml

@@ -230,9 +230,3 @@ spec:
        type: object
    served: true
    storage: true
-status:


no status anymore?

More details in kubernetes-sigs/controller-tools#630. But looks like no status for CRD objects during generation (I think server will still write status field).

Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.8.0 to 0.9.2. - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.8.0...v0.9.2) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Some fields defined as `interface{}` cause problems with controller-tools v0.9.2. This change removes kubebuilder markers so that controller-gen is not going to try to generate deepcopy functions for the data structures in this package.

v0.9.2 controller-gen removes status fields from CRD generation (for good reason). This is the output after running `make manifests`.

dependabot · 2022-09-22T04:47:16Z

A newer version of sigs.k8s.io/controller-tools exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

rajathagasthya · 2022-09-26T17:12:53Z

Closing to let dependabot create a new PR with newer controller-tools version.

dependabot · 2022-09-26T17:12:55Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

rajathagasthya · 2022-09-26T17:13:36Z

@dependabot recreate

dependabot · 2022-09-26T17:13:39Z

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

rajathagasthya · 2022-09-26T17:14:14Z

@dependabot reopen

rajathagasthya · 2022-09-26T17:15:58Z

(Again)
Closing to let dependabot create a new PR with newer controller-tools version.

dependabot bot requested a review from a team as a code owner June 30, 2022 14:20

dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 30, 2022

dependabot bot mentioned this pull request Jun 30, 2022

Bump sigs.k8s.io/controller-tools from 0.8.0 to 0.9.1 in /hack/tools #2783

Closed

dependabot bot requested review from imikushin and a team June 30, 2022 14:20

vmwclabot added the cla-not-required label Jun 30, 2022

rajathagasthya force-pushed the dependabot/go_modules/hack/tools/sigs.k8s.io/controller-tools-0.9.2 branch from ccea32b to f85e8e4 Compare July 1, 2022 19:40

rajathagasthya added the good first issue Good for newcomers label Jul 18, 2022

rajathagasthya force-pushed the dependabot/go_modules/hack/tools/sigs.k8s.io/controller-tools-0.9.2 branch from f85e8e4 to 62f46c7 Compare July 26, 2022 17:51

rajathagasthya added the ok-to-merge PRs should be labelled with this before merging label Jul 26, 2022

codegold79 approved these changes Jul 26, 2022

View reviewed changes

yharish991 approved these changes Aug 1, 2022

View reviewed changes

vijaykatam reviewed Aug 1, 2022

View reviewed changes

dependabot bot and others added 3 commits August 3, 2022 10:15

Remove kubebuilder markers for test file

271b23e

Some fields defined as `interface{}` cause problems with controller-tools v0.9.2. This change removes kubebuilder markers so that controller-gen is not going to try to generate deepcopy functions for the data structures in this package.

Update generated CRDs from controller-gen

ce59d21

v0.9.2 controller-gen removes status fields from CRD generation (for good reason). This is the output after running `make manifests`.

rajathagasthya force-pushed the dependabot/go_modules/hack/tools/sigs.k8s.io/controller-tools-0.9.2 branch from 62f46c7 to ce59d21 Compare August 3, 2022 15:15

rajathagasthya closed this Sep 26, 2022

rajathagasthya deleted the dependabot/go_modules/hack/tools/sigs.k8s.io/controller-tools-0.9.2 branch September 26, 2022 17:12

dependabot bot reopened this Sep 26, 2022

dependabot bot restored the dependabot/go_modules/hack/tools/sigs.k8s.io/controller-tools-0.9.2 branch September 26, 2022 17:14

rajathagasthya closed this Sep 26, 2022

dependabot bot deleted the dependabot/go_modules/hack/tools/sigs.k8s.io/controller-tools-0.9.2 branch September 26, 2022 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump sigs.k8s.io/controller-tools from 0.8.0 to 0.9.2 in /hack/tools #2795

Bump sigs.k8s.io/controller-tools from 0.8.0 to 0.9.2 in /hack/tools #2795

dependabot bot commented on behalf of github Jun 30, 2022

codecov bot commented Jul 26, 2022 •

edited

Loading

yharish991 left a comment

rajathagasthya commented Aug 1, 2022

vijaykatam Aug 1, 2022

rajathagasthya Aug 1, 2022

vijaykatam Aug 1, 2022

rajathagasthya Aug 1, 2022

rajathagasthya Aug 1, 2022

vijaykatam Aug 1, 2022

rajathagasthya Aug 1, 2022

vijaykatam Aug 1, 2022

rajathagasthya Aug 1, 2022

dependabot bot commented on behalf of github Sep 22, 2022

rajathagasthya commented Sep 26, 2022

dependabot bot commented on behalf of github Sep 26, 2022

rajathagasthya commented Sep 26, 2022

dependabot bot commented on behalf of github Sep 26, 2022

rajathagasthya commented Sep 26, 2022

rajathagasthya commented Sep 26, 2022

Bump sigs.k8s.io/controller-tools from 0.8.0 to 0.9.2 in /hack/tools #2795

Bump sigs.k8s.io/controller-tools from 0.8.0 to 0.9.2 in /hack/tools #2795

Conversation

dependabot bot commented on behalf of github Jun 30, 2022

v0.9.2

🐛 Bug Fixes

v0.9.1

✨ New Features

🐛 Bug Fixes

🌱 Others

v0.9.0

✨ New Features

🐛 Bug Fixes

codecov bot commented Jul 26, 2022 • edited Loading

Codecov Report

yharish991 left a comment

Choose a reason for hiding this comment

rajathagasthya commented Aug 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Sep 22, 2022

rajathagasthya commented Sep 26, 2022

dependabot bot commented on behalf of github Sep 26, 2022

rajathagasthya commented Sep 26, 2022

dependabot bot commented on behalf of github Sep 26, 2022

rajathagasthya commented Sep 26, 2022

rajathagasthya commented Sep 26, 2022

codecov bot commented Jul 26, 2022 •

edited

Loading