Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional labels and annotations on velero CLI generated YAML #4982

Open
yogeek opened this issue Jun 10, 2022 · 2 comments
Open

Support additional labels and annotations on velero CLI generated YAML #4982

yogeek opened this issue Jun 10, 2022 · 2 comments

Comments

@yogeek
Copy link

yogeek commented Jun 10, 2022

Describe the problem/challenge you have
We installed velero with velero install command and it worked well. But we recently added a kyverno policy that checked if a specific label is existing on all namespaces, and this causes a policy violation each time the velero pipeline is launched because the label is missing on velero namespace.
The namespace is generated by the CLI each time the velero install command is launched and it seems not possible to add labels or annotations to resources generated by the CLI.

Describe the solution you'd like
The velero install command could support additional labels and annotations to be compliant to policy engines rules.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

@yogeek I think there are --pod-annotations and --pod-labels are you saying you want this label applied to other resources? or the velero ns only?

@yogeek
Copy link
Author

yogeek commented Jun 13, 2022

@reasonerjt thank you for your help. Having the possibility to add labels to the namespace would be helpful in our case.
Regarding the design, I do not know what would be better between a new option specific for the namespace (--namespace-labels and --namespace-annotations) or renaming the --pod-labels and --pod-annotations to --additional-labels and --additional-annotations (that would be applied to both namespace and pods) would be better...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants