Support install label and annotations on velero CLI installation resources #6152
+324
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
issue4982
branch
2 times, most recently
from
59937b5
to
8baef81
Compare
Codecov Report
@@ Coverage Diff @@
## main #6152 +/- ##
==========================================
- Coverage 41.28% 41.17% -0.12%
==========================================
Files 251 252 +1
Lines 23399 23698 +299
==========================================
+ Hits 9661 9758 +97
- Misses 12979 13168 +189
- Partials 759 772 +13
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…urces Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
This was referenced Apr 15, 2023
|
@kaovilai Sorry for the late response, but could you elaborate on why this is needed? |
|
I was just helping close "help wanted" issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus added unit test for install.Run() to cover the added features. Can add to this "end to end" install unit test in the future.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #4982
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.