Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the Ginkgo version to v2 #7872

Open
4 of 5 tasks
blackpiglet opened this issue Jun 12, 2024 · 5 comments
Open
4 of 5 tasks

Bump the Ginkgo version to v2 #7872

blackpiglet opened this issue Jun 12, 2024 · 5 comments
Assignees
Labels
E2E Tests End to end test Epic
Milestone

Comments

@blackpiglet
Copy link
Contributor

blackpiglet commented Jun 12, 2024

Describe the problem/challenge you have

Ginkgo v2 supports more features, and the Ginkgo v1 is not maintained anymore.
https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#upgrading-to-ginkgo-20
https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#aborting-the-test-suite

Propose to upgrade the Velero E2E using Ginkgo to v2 to utilize the new functionality.

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@blackpiglet blackpiglet added the E2E Tests End to end test label Jun 12, 2024
@blackpiglet blackpiglet self-assigned this Jun 12, 2024
@reasonerjt reasonerjt added this to the v1.15 milestone Jun 21, 2024
@kaovilai
Copy link
Contributor

We've done this in OADP in the past. If you can break the tasks out I can assist here.

@blackpiglet
Copy link
Contributor Author

@kaovilai
Great.
Were there any issues or PRs on the OADP side that I can take as a reference?

@kaovilai
Copy link
Contributor

This is the main one we did to move to v2 openshift/oadp-operator#560

I think we had a mix of both in go.mod initially but eventually removed v1 references.

@kaovilai
Copy link
Contributor

Last v1 removal was simply

-	"github.com/onsi/ginkgo"
+	"github.com/onsi/ginkgo/v2"

@blackpiglet
Copy link
Contributor Author

@kaovilai
Thanks.
After reading some Ginkgo documents, I broke this Epic task into sub-tasks.
I'm still getting familiar with the Ginkgo framework. There could be something inaccurate, or something important is still missing.
Appreciate any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests End to end test Epic
Projects
None yet
Development

No branches or pull requests

3 participants