Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ginkgo to v2 #7961

Open
blackpiglet opened this issue Jul 1, 2024 · 2 comments
Open

Bump Ginkgo to v2 #7961

blackpiglet opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
E2E Tests End to end test

Comments

@blackpiglet
Copy link
Contributor

Describe the problem/challenge you have

Bump Ginkgo to v2, and resolve potential conflicts.
https://onsi.github.io/ginkgo/MIGRATING_TO_V2#major-changes

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@blackpiglet blackpiglet added the E2E Tests End to end test label Jul 1, 2024
@blackpiglet blackpiglet self-assigned this Jul 1, 2024
@kaovilai
Copy link
Contributor

kaovilai commented Jul 1, 2024

I think #7957 should be part of this issue just because without it, you cannot remove v1 references.

@blackpiglet
Copy link
Contributor Author

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests End to end test
Projects
None yet
Development

No branches or pull requests

2 participants