Upgrade to client-go v5.0.1, kubernetes v1.8.2 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
reviewed
Oct 30, 2017
pkg/cmd/util/output/output.go
Outdated
| @@ -168,7 +168,7 @@ func NewPrinter(cmd *cobra.Command) (*printers.HumanReadablePrinter, error) { | |||
|
|
|||
| printer := printers.NewHumanReadablePrinter( | |||
| encoder, | |||
| scheme.Codecs.UniversalDecoder(api.SchemeGroupVersion), | |||
| scheme.Codecs.UniversalDecoder(v1.SchemeGroupVersion), | |||
There was a problem hiding this comment.
was this another instance where we were using the wrong SchemeGroupVersion? Since this is switching from core/v1 to ark/v1
There was a problem hiding this comment.
Yeah, I'm wondering if it matters...
There was a problem hiding this comment.
Ok I just read the HumanReadablePrinter code. If we specify encoder & decoder, and if the object is runtime.Unstructured or *runtime.Unknown, it attempts to encode to bytes and then immediately decode it using the decoder to an actual type. Given that we are printing our types using our real client, I think we can pass nil for encoder & decoder. WDYT?
There was a problem hiding this comment.
Pushed a new commit removing them
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Update k8s.io/kubernetes to v1.8. Update k8s.io/client-go to v5.0.0 Update k8s.io/apimachinery to match Pull in k8s.io/api release-1.8 branch Pull in k8s.io/code-generator release-1.8 branch Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Fix genclient tags Add deepcopy-gen interfaces to top level types Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
dynamicClient.Resource() now returns an interface Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
These were for the upgrade from client-go v4.x to v5.x. Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
The generated clientsets use this package, but there are no explicit imports, so we have to manually require it. Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Remove verifying gofmt from hack/test.sh. Make sure hack/update-fmt.sh ignores zz_generated files. Enable code simplification for gofmt. Add hack/verify-fmt.sh. Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
We only need them if we've got unstructured/unknown data and we want to convert it to typed objects. Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
|
@ncdc this looks good to me - ready to merge? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switch to using k8s.io/code-generator