Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort output of resource list in velero backup describe --details #1741

Merged
merged 3 commits into from
Aug 9, 2019
Merged

sort output of resource list in velero backup describe --details #1741

merged 3 commits into from
Aug 9, 2019

Conversation

prydonius
Copy link
Contributor

fixes #1731

Signed-off-by: Adnan Abdulhussein aadnan@vmware.com

Adnan Abdulhussein added 2 commits August 8, 2019 13:53
ensure backup resource list per gvk is sorted
faef20d 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
changelog
f18d730 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@prydonius prydonius mentioned this pull request Aug 8, 2019
Closed
sort GVKs in output
92b930d 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@prydonius prydonius changed the title persist sorted list of backed up resources in object storage sort output of resource list in velero backup describe --details Aug 8, 2019
@prydonius
Copy link
Contributor Author

Updated as per #1731 (comment)

skriss
skriss approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you confirm go test ./pkg/backup -count 100 passes?

@prydonius
Copy link
Contributor Author

Nice didn't know about that option! Looks okay:

> go test ./pkg/backup -count 100
ok  	github.com/heptio/velero/pkg/backup	5.771s

@skriss
Copy link
Member

skriss commented Aug 8, 2019

It's v useful when dealing with flakes :)

@nrb nrb mentioned this pull request Aug 9, 2019
Merged
@nrb nrb added this to the v1.1 milestone Aug 9, 2019
@nrb nrb merged commit ad02610 into vmware-tanzu:master Aug 9, 2019
@prydonius prydonius deleted the 1731-sort-resource-list branch August 9, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb approved these changes

@skriss skriss skriss approved these changes

@carlisia carlisia Awaiting requested review from carlisia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

sort output of resource list in velero backup describe --details
3 participants
@prydonius @skriss @nrb