Support AWS_PROFILE for restic backups/restore operations #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It enables Velero to switch credentials if multiple s3-compatible backupLocations are present. Signed-off-by: dinesh <dinesh1042@gmail.com>
Signed-off-by: dinesh <dinesh1042@gmail.com>
|
@skriss tried incorporating your comments, please have a look. |
|
thanks for the updates! |
|
I haven't actually tested, but the code LGTM and @dinesh has tested successfully. @dinesh can you also add a changelog for this PR? See https://velero.io/docs/master/code-standards/ for details. |
Signed-off-by: dinesh <dinesh1042@gmail.com>
|
@skriss added. |
|
@nrb @carlisia @prydonius PTAL. |
skriss
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2033
It enables Velero to switch credentials if multiple s3-compatible backupLocations are present.