fix race condition in waiting for restic restores to complete #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looked good to me in testing, ready for review here. |
Signed-off-by: Steve Kriss <krisss@vmware.com>
dymurray
previously approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Using a channel to wait for the restic restores to finish makes a lot of sense to me. Would be curious to see if this resolves the issue seen in our environment with the restic restore running out of disk space. Either way this change is an improvement to the way this currently functions.
ashish-amarnath
suggested changes
Jan 21, 2020
Signed-off-by: Steve Kriss <krisss@vmware.com>
ashish-amarnath
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss krisss@vmware.com
closes #2121
cc @dymurray
Basic validation on this looks good, but I'd like to do some more testing before merging so leaving in draft status.