Create restore-hooks_product-requirements.md #2699
Conversation
There was a problem hiding this comment.
Thanks for getting this in @stephbman, and sorry I didn't look at it sooner! I have some questions about the wording on a few of the use cases, and just want to be sure I'm clear on them before we move forward on it.
|
|
||
| For questions, please contact michaelmi@vmware.com, [bstephanie@vmware.com](mailto:bstephanie@vmware.com) | ||
|
|
||
| Signed-off-by: Stephanie Bauman bstephanie@vmware.com |
There was a problem hiding this comment.
This line can be removed - it only needs to be on the git commit message :)
nrb
added
Breaking change
| **Title: **Check for latest snapshot | ||
|
|
||
|
|
||
| **Description: **As a user, I would like Velero to run a check for the latest snapshot in object storage prior to starting restore operations on a pod. |
There was a problem hiding this comment.
There is a 1:1 mapping between restores and backups and backups have volumesnapshots in them.
On restoring from a backup, the volumesnapshots from that backup are what are used to restore data into the volumes.
IMO, changing that behavior, to choose a volumesnapshot, different from the one in the backup, is out of scope for this feature.
There was a problem hiding this comment.
This use case is not changing that behavior. Rather, the use case specifies that as part of restore requirements for the product, we want the restore to use the latest volumesnapshot available (latest meaning the volume snapshot that has the most recent timestamp).
On restoring from backup, we want to make sure that our restore requirements leverage the actions and the 1:1 mapping between restores and backups and that the behavior is not changed.
There was a problem hiding this comment.
Quick clarification. Every volume will have exactly one snapshot in a backup which is the one that will be picked up when a user restores from that backup. Current;ly, we do not choose a snapshot with the latest timestamp, instead we will choose a snapshot that is in the backup- this may or may not be the latest snapshot.
That is the reason why this requirement seems like a change in behavior which is out of scope.
There was a problem hiding this comment.
Velero will use the snapshot that is in the backup being restored.
| **Title: **Check for latest snapshot | ||
|
|
||
|
|
||
| **Description: **As a user, I would like Velero to run a check for the latest snapshot in object storage prior to starting restore operations on a pod. |
There was a problem hiding this comment.
This use case is not changing that behavior. Rather, the use case specifies that as part of restore requirements for the product, we want the restore to use the latest volumesnapshot available (latest meaning the volume snapshot that has the most recent timestamp).
On restoring from backup, we want to make sure that our restore requirements leverage the actions and the 1:1 mapping between restores and backups and that the behavior is not changed.
| **Title: **Check for latest snapshot | ||
|
|
||
|
|
||
| **Description: **As a user, I would like Velero to run a check for the latest snapshot in object storage prior to starting restore operations on a pod. |
There was a problem hiding this comment.
Quick clarification. Every volume will have exactly one snapshot in a backup which is the one that will be picked up when a user restores from that backup. Current;ly, we do not choose a snapshot with the latest timestamp, instead we will choose a snapshot that is in the backup- this may or may not be the latest snapshot.
That is the reason why this requirement seems like a change in behavior which is out of scope.
ashish-amarnath
force-pushed
the
stephbman-patch-1
branch
from
57339a5
to
d009c9e
Compare
ashish-amarnath
force-pushed
the
stephbman-patch-1
branch
from
d009c9e
to
28136d3
Compare
ashish-amarnath
force-pushed
the
stephbman-patch-1
branch
from
28136d3
to
a5028b2
Compare
ashish-amarnath
force-pushed
the
stephbman-patch-1
branch
from
a5028b2
to
20b9f53
Compare
| ``` | ||
| pre.hook.restore.velero.io/container | ||
|
|
||
| kubectl patch backupstoragelocation <STORAGE LOCATION NAME> \ |
There was a problem hiding this comment.
What's the purpose of setting the backup storage location to read only here?
There was a problem hiding this comment.
I have the same question.
|
@carlisia leaving the merge for you bc you had some open questions. |
There was a problem hiding this comment.
@stephbman when you have a chance please let us know: #2699 (comment)
Restore Hooks Design Proposal Signed-off-by: Stephanie Bauman <bstephanie@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
Restore Hooks Design Proposal Signed-off-by: Stephanie Bauman <bstephanie@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
Restore Hooks Design Proposal Signed-off-by: Stephanie Bauman <bstephanie@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
Restore Hooks Design Proposal Signed-off-by: Stephanie Bauman <bstephanie@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
Restore Hooks Design Proposal Signed-off-by: Stephanie Bauman <bstephanie@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
Restore Hooks Design Proposal Signed-off-by: Stephanie Bauman <bstephanie@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
This file contains the MVP use cases and product requirements tied the Restore Hooks Design Proposal #2465.
This requirements document ties to Epic: #2116
And is related to issue: #2678
Signed-off-by: Stephanie Bauman, bstephanie@vmware.com