Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibm object storage #321

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Ibm object storage #321

merged 1 commit into from
Mar 6, 2018

Conversation

roytman
Copy link
Contributor

@roytman roytman commented Feb 20, 2018

Add a configuration option to use IBM Cloud Object Storage as Ark's backups destination.

@ncdc
Copy link
Contributor

ncdc commented Feb 21, 2018

Hi @roytman, thanks for your PR! We'll review this soon and get back to you with any feedback we may have.

@ncdc
Copy link
Contributor

ncdc commented Feb 26, 2018

@roytman we haven't forgotten about this! @Bradamant3 is busy at the moment with other things, but she'll hopefully be able to review starting this Wednesday. Thanks for your patience!

@roytman
Copy link
Contributor Author

roytman commented Feb 26, 2018

Hi Andy, thanks for the update. No problem, it can wait.

@roytman
Copy link
Contributor Author

roytman commented Mar 2, 2018

Hi Andy @ncdc, I updated the ibm-config.md according to the latest Ark v0.7.0 namespace policy.
P.S in the README.md the command
kubectl get deployments -l component=ark --namespace=heptio-ark
should be replaced by
kubectl get deployments -l component=ark --namespace=heptio-ark-server

@Bradamant3
Copy link
Contributor

My apologies! I thought that I had reviewed here, so sorry.
Docs LGTM, with additional apologies for merging a change that means you need to rebase :-(
I'd like to make a few copyedits, but let's get this PR merged first, and then I can ask @roytman to review my changes in a subsequent PR. My changes will be stylistic only, but it's always good to make sure I don't accidentally change technical meaning.

@ncdc
Copy link
Contributor

ncdc commented Mar 5, 2018

@roytman thanks for the info about the readme. We'll get that fixed. If you can rebase this PR, we'll merge it asap.

@ncdc
Copy link
Contributor

ncdc commented Mar 5, 2018

@roytman it looks like you're having git issues? Need any help?

@roytman roytman force-pushed the ibm-object-storage branch 2 times, most recently from 43bc79f to 933a01f Compare March 6, 2018 11:13
@roytman
Copy link
Contributor Author

roytman commented Mar 6, 2018

@ncdc thanks for the help suggestion. The PR was rebased.

gcSyncPeriod: 1m
scheduleSyncPeriod: 1m
restoreOnlyMode: false
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't required

region: <YOUR_REGION>
s3ForcePathStyle: "true"
s3Url: <YOUR_URL_ACCESS_POINT>
backupSyncPeriod: 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other examples have 30m - want to be consistent?

s3ForcePathStyle: "true"
s3Url: <YOUR_URL_ACCESS_POINT>
backupSyncPeriod: 1m
gcSyncPeriod: 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other examples have 30m - want to be consistent?

@@ -0,0 +1,32 @@
# Copyright 2017 the Heptio Ark contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018 😄

@roytman
Copy link
Contributor Author

roytman commented Mar 6, 2018

Hi @ncdc, thanks for the comments. I updated the file.

@ncdc
Copy link
Contributor

ncdc commented Mar 6, 2018

LGTM. Please squash & I'll merge. Thanks!

Signed-off-by: roytman@il.ibm.com <roytman@il.ibm.com>
@roytman roytman force-pushed the ibm-object-storage branch from 801431d to 5cc29e0 Compare March 6, 2018 15:46
@roytman
Copy link
Contributor Author

roytman commented Mar 6, 2018

Done

@ncdc ncdc merged commit fd579f5 into vmware-tanzu:master Mar 6, 2018
@ncdc ncdc added this to the v0.8.0 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants