-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibm object storage #321
Ibm object storage #321
Conversation
c3db5b7
to
a70c452
Compare
Hi @roytman, thanks for your PR! We'll review this soon and get back to you with any feedback we may have. |
@roytman we haven't forgotten about this! @Bradamant3 is busy at the moment with other things, but she'll hopefully be able to review starting this Wednesday. Thanks for your patience! |
Hi Andy, thanks for the update. No problem, it can wait. |
Hi Andy @ncdc, I updated the ibm-config.md according to the latest Ark v0.7.0 namespace policy. |
My apologies! I thought that I had reviewed here, so sorry. |
@roytman thanks for the info about the readme. We'll get that fixed. If you can rebase this PR, we'll merge it asap. |
@roytman it looks like you're having git issues? Need any help? |
43bc79f
to
933a01f
Compare
@ncdc thanks for the help suggestion. The PR was rebased. |
examples/ibm/00-ark-config.yaml
Outdated
gcSyncPeriod: 1m | ||
scheduleSyncPeriod: 1m | ||
restoreOnlyMode: false | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isn't required
examples/ibm/00-ark-config.yaml
Outdated
region: <YOUR_REGION> | ||
s3ForcePathStyle: "true" | ||
s3Url: <YOUR_URL_ACCESS_POINT> | ||
backupSyncPeriod: 1m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other examples have 30m
- want to be consistent?
examples/ibm/00-ark-config.yaml
Outdated
s3ForcePathStyle: "true" | ||
s3Url: <YOUR_URL_ACCESS_POINT> | ||
backupSyncPeriod: 1m | ||
gcSyncPeriod: 1m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other examples have 30m
- want to be consistent?
examples/ibm/00-ark-config.yaml
Outdated
@@ -0,0 +1,32 @@ | |||
# Copyright 2017 the Heptio Ark contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018 😄
Hi @ncdc, thanks for the comments. I updated the file. |
LGTM. Please squash & I'll merge. Thanks! |
Signed-off-by: roytman@il.ibm.com <roytman@il.ibm.com>
801431d
to
5cc29e0
Compare
Done |
Add a configuration option to use IBM Cloud Object Storage as Ark's backups destination.