Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests now run in multiple clouds in addition to KIND #3286

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

dsu-igeek
Copy link
Contributor

Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added dump of velero describe and logs on error

Signed-off-by: Dave Smith-Uchida dsmithuchida@vmware.com

@zubron zubron added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 25, 2021
test/e2e/Makefile Outdated Show resolved Hide resolved
test/e2e/velero_utils.go Outdated Show resolved Hide resolved
test/e2e/velero_utils.go Show resolved Hide resolved
test/e2e/velero_utils.go Show resolved Hide resolved
test/e2e/e2e_suite_test.go Show resolved Hide resolved
@dsu-igeek dsu-igeek linked an issue Jan 25, 2021 that may be closed by this pull request
@github-actions github-actions bot requested a review from zubron January 26, 2021 05:21
@nrb nrb added the kind/release-blocker Must fix issues for the coming release (milestone) label Feb 3, 2021
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, @dsu-igeek. There is a codespell error blocking it from merging but otherwise it's good. Once the CI checks are green, I'll approve (pretty sure GitHub will dismiss my review once you make a change).

Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me except for the codespell error. Like Bridget, I'll save approval til that's fixed.

test/e2e/velero_utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only blocking change I see here is to clean up CRDs on uninstall., or at least provide the option.

I can see leaving them in when testing upgrade scenarios, but to get a clean cluster, this second step is needed.

@nrb nrb added this to the v1.6.0 milestone Feb 10, 2021
@github-actions github-actions bot requested a review from nrb February 11, 2021 00:17
nrb
nrb previously requested changes Feb 11, 2021
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor code reuse change, then I'm 👍

test/e2e/velero_utils.go Outdated Show resolved Hide resolved
@jenting
Copy link
Contributor

jenting commented Feb 12, 2021

The CI is failed at import ordering

@dsu-igeek dsu-igeek force-pushed the e2e-cloud-tests-01-14-2021 branch 2 times, most recently from d643173 to ab1429c Compare February 16, 2021 17:13
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

test/e2e/README.md Outdated Show resolved Hide resolved
Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added remove of CRDs to test v elero uninstall
Added remove of cluster role binding to test velero uninstall
Added dump of velero describe and logs on error
Added velero namespace argument to velero_utils functions
Modified api group versions e2e tests to use VeleroInstall
Added velero logs dumps for api group versions e2e testing
Added DeleteNamespace to test/e2e/common.go
Fixed VeleroInstall to use the image specified
Changed enable_api_group_versions_test to use veleroNamespace instead of hardcoded "velero"

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dsu-igeek!

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenting jenting dismissed nrb’s stale review February 19, 2021 00:16

The issue had been resolved.

@jenting jenting merged commit 45d5317 into vmware-tanzu:main Feb 19, 2021
sfelix-orange pushed a commit to sfelix-orange/velero that referenced this pull request Feb 25, 2021
…u#3286)

Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added remove of CRDs to test v elero uninstall
Added remove of cluster role binding to test velero uninstall
Added dump of velero describe and logs on error
Added velero namespace argument to velero_utils functions
Modified api group versions e2e tests to use VeleroInstall
Added velero logs dumps for api group versions e2e testing
Added DeleteNamespace to test/e2e/common.go
Fixed VeleroInstall to use the image specified
Changed enable_api_group_versions_test to use veleroNamespace instead of hardcoded "velero"

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
Signed-off-by: Sebastien FELIX <sebastien.felix.ext@orange.com>
sfelix-orange pushed a commit to sfelix-orange/velero that referenced this pull request Feb 25, 2021
…u#3286)

Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added remove of CRDs to test v elero uninstall
Added remove of cluster role binding to test velero uninstall
Added dump of velero describe and logs on error
Added velero namespace argument to velero_utils functions
Modified api group versions e2e tests to use VeleroInstall
Added velero logs dumps for api group versions e2e testing
Added DeleteNamespace to test/e2e/common.go
Fixed VeleroInstall to use the image specified
Changed enable_api_group_versions_test to use veleroNamespace instead of hardcoded "velero"

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
Signed-off-by: Sebastien FELIX <sebastien.felix.ext@orange.com>
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
…u#3286)

Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added remove of CRDs to test v elero uninstall
Added remove of cluster role binding to test velero uninstall
Added dump of velero describe and logs on error
Added velero namespace argument to velero_utils functions
Modified api group versions e2e tests to use VeleroInstall
Added velero logs dumps for api group versions e2e testing
Added DeleteNamespace to test/e2e/common.go
Fixed VeleroInstall to use the image specified
Changed enable_api_group_versions_test to use veleroNamespace instead of hardcoded "velero"

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
…u#3286)

Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added remove of CRDs to test v elero uninstall
Added remove of cluster role binding to test velero uninstall
Added dump of velero describe and logs on error
Added velero namespace argument to velero_utils functions
Modified api group versions e2e tests to use VeleroInstall
Added velero logs dumps for api group versions e2e testing
Added DeleteNamespace to test/e2e/common.go
Fixed VeleroInstall to use the image specified
Changed enable_api_group_versions_test to use veleroNamespace instead of hardcoded "velero"

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
@dsu-igeek dsu-igeek deleted the e2e-cloud-tests-01-14-2021 branch September 11, 2021 06:15
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
…u#3286)

Split plug-in provider into cloud provider/object provider
Moved velero install/uninstall for tests into velero_utils
Added remove of CRDs to test v elero uninstall
Added remove of cluster role binding to test velero uninstall
Added dump of velero describe and logs on error
Added velero namespace argument to velero_utils functions
Modified api group versions e2e tests to use VeleroInstall
Added velero logs dumps for api group versions e2e testing
Added DeleteNamespace to test/e2e/common.go
Fixed VeleroInstall to use the image specified
Changed enable_api_group_versions_test to use veleroNamespace instead of hardcoded "velero"

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes kind/release-blocker Must fix issues for the coming release (milestone)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests install/run in AWS, Azure, vSphere and KIND
4 participants