Remove Azure location requirement #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to have worked for me, but I'd like a 2nd look as it appears I also had some Azure permissions issues. I don't believe they're related, but want to be sure. |
skriss
suggested changes
Mar 5, 2018
| @@ -100,7 +100,6 @@ No parameters required. | |||
|
|
|||
| | Key | Type | Default | Meaning | | |||
| | --- | --- | --- | --- | | |||
| | `location` | string | Required Field | *Example*: "Canada East"<br><br>See [the list of available locations][5] (note that this particular page refers to them as "Regions"). | | |||
Instead of requiring the Ark admin to specify a "location" in the azure persistentVolumeProvider config (meaning only a single location is supported), get info about the disk (for its location) when creating a snapshot, and get info about the snapshot (for its location) when creating a disk from a snapshot. Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com>
ncdc
force-pushed
the
remove-azure-location-requirement
branch
from
6389a71 to
331e0c2
Compare
|
@skriss fixed and rebased on top of latest master |
skriss
approved these changes
Mar 5, 2018
|
LGTM |
weshayutin
pushed a commit
to weshayutin/velero
that referenced
this pull request
Jan 15, 2025
This fixes the PR vmware-tanzu#334 where one additional line was in the code. This was not exposed previously as we did not had downstream CI Lint jobs. Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-authored-by: Michal Pryc <mpryc@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring the Ark admin to specify a "location" in the azure
persistentVolumeProvider config (meaning only a single location is
supported), get info about the disk (for its location) when creating a
snapshot, and get info about the snapshot (for its location) when
creating a disk from a snapshot.
Signed-off-by: Andy Goldstein andy.goldstein@gmail.com