only save/use iops for io1 volumes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <steve@heptio.com>
ncdc
suggested changes
Aug 14, 2017
pkg/apis/ark/v1/backup.go
Outdated
| @@ -111,7 +111,7 @@ type VolumeBackupInfo struct { | |||
|
|
|||
| // Iops is the optional value of provisioned IOPS for the | |||
| // disk/volume in the cloud provider API. | |||
| Iops *int `json:"iops"` | |||
| Iops *int `json:"iops,omitempty"` | |||
There was a problem hiding this comment.
Should we make this *int64 to match the type returned by the aws call?
| if vol.Iops != nil { | ||
| iops = int(*vol.Iops) | ||
| if iopsVolumeTypes.Has(volumeType) && vol.Iops != nil { | ||
| iopsVal := int(*vol.Iops) |
There was a problem hiding this comment.
If we make the change above in backup.go to *int64, this logic can be simplified:
var iops *int64
if iopsVolumeTypes.Has(volumeType) && vol.Iops != nil {
iops = vol.Iops
}right?
Signed-off-by: Steve Kriss <steve@heptio.com>
ncdc
approved these changes
Aug 14, 2017
jmontleon
pushed a commit
to jmontleon/velero
that referenced
this pull request
Dec 10, 2019
…1.1-gofmt gofmt fix for gcp snapshot change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss steve@heptio.com