Insert all restore errors and warnings into restore log #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a user inspecting the restore logs to see any errors or warnings generated by the restore so that they will be seen even without having to use the describe cli. Signed-off-by: Scott Seago <sseago@redhat.com>
sseago
force-pushed
the
restore-warning-logs
branch
from
39a2a54
to
f01d529
Compare
Codecov Report
@@ Coverage Diff @@
## main #4743 +/- ##
==========================================
- Coverage 40.81% 40.75% -0.07%
==========================================
Files 202 202
Lines 17972 17994 +22
==========================================
- Hits 7336 7334 -2
- Misses 10116 10134 +18
- Partials 520 526 +6
Continue to review full report at Codecov.
|
dymurray
approved these changes
Mar 16, 2022
qiuming-best
approved these changes
Mar 21, 2022
reasonerjt
approved these changes
Mar 21, 2022
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…#4743) This allows a user inspecting the restore logs to see any errors or warnings generated by the restore so that they will be seen even without having to use the describe cli. Signed-off-by: Scott Seago <sseago@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Seago sseago@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
This allows a user inspecting the restore logs to see any
errors or warnings generated by the restore so that they
will be seen even without having to use the describe cli.
Does your change fix a particular issue?
Fixes #4742
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.