Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default restorePriorities docs #517

Merged
merged 2 commits into from
May 26, 2018

Conversation

cknowles
Copy link
Contributor

@cknowles cknowles commented May 26, 2018

Changed in #258

Changed in vmware-tanzu#258

Signed-off-by: Chris Knowles <c-knowles@users.noreply.github.com>
@cknowles cknowles changed the title Correct default restorePriorities Correct default restorePriorities docs May 26, 2018
@ncdc
Copy link
Contributor

ncdc commented May 26, 2018

@c-knowles thanks for the PR! Since you're updating this, there's another entry that's missing. Here is the full current list: https://github.com/heptio/ark/blob/6dbde599bfac0ee0f38f0880b51664bd8b576c67/pkg/cmd/server/server.go#L309-L317. Would you mind including limitranges too?

Signed-off-by: Chris Knowles <c-knowles@users.noreply.github.com>
@cknowles cknowles force-pushed the bug/doc-default-resourcePriorities branch from dda206e to 4065c0f Compare May 26, 2018 12:23
@cknowles
Copy link
Contributor Author

Sure, done.

@ncdc
Copy link
Contributor

ncdc commented May 26, 2018

LGTM, thanks!

@ncdc ncdc merged commit 10d6dd0 into vmware-tanzu:master May 26, 2018
@cknowles cknowles deleted the bug/doc-default-resourcePriorities branch May 29, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants