Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIAv2 async operations controller work #5993

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Mar 17, 2023

Thank you for contributing to Velero!

This includes the restore controller work for RestoreItemAction v2 implementation.

Fixes #5497

Please indicate you've done the following:

  • [ x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago
Copy link
Collaborator Author

sseago commented Mar 17, 2023

It's not quite merge-ready as I still need to do some testing with real restores and real plugins, but it's otherwise ready for review.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #5993 (ef43511) into main (117d5e8) will increase coverage by 0.04%.
The diff coverage is 48.58%.

❗ Current head ef43511 differs from pull request most recent head 83a7a29. Consider uploading reports for the commit 83a7a29 to get more accurate results

@@            Coverage Diff             @@
##             main    #5993      +/-   ##
==========================================
+ Coverage   40.18%   40.23%   +0.04%     
==========================================
  Files         256      257       +1     
  Lines       23426    23820     +394     
==========================================
+ Hits         9414     9583     +169     
- Misses      13297    13493     +196     
- Partials      715      744      +29     
Impacted Files Coverage Δ
pkg/builder/restore_builder.go 0.00% <0.00%> (ø)
pkg/cmd/server/server.go 5.30% <0.00%> (-0.15%) ⬇️
pkg/cmd/util/output/restore_describer.go 0.00% <0.00%> (ø)
pkg/persistence/object_store.go 52.35% <0.00%> (ø)
...reitemaction/v2/restartable_restore_item_action.go 63.75% <0.00%> (-3.36%) ⬇️
pkg/controller/restore_operations_controller.go 52.17% <52.17%> (ø)
pkg/controller/restore_controller.go 64.94% <62.16%> (-2.37%) ⬇️
pkg/controller/download_request_controller.go 66.66% <71.42%> (-1.56%) ⬇️
pkg/restore/request.go 100.00% <100.00%> (ø)
pkg/restore/restore.go 64.28% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Scott Seago <sseago@redhat.com>
@sseago sseago force-pushed the riav2-controller branch from 83a7a29 to 2155b2b Compare March 17, 2023 18:30
@sseago
Copy link
Collaborator Author

sseago commented Mar 18, 2023

I've now tested this with the velero-plugin-example PR which has a recently-added RIAv2 plugin.

@Lyndon-Li Lyndon-Li self-requested a review March 20, 2023 03:38
@Lyndon-Li Lyndon-Li self-assigned this Mar 20, 2023
@shubham-pampattiwar shubham-pampattiwar merged commit 5c4b550 into vmware-tanzu:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement restore monitoring for restoreItemAction
4 participants