Add userid to ark alias #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@carsonoid thanks for your pull request! This is a good idea 😄. Would you mind signing your commit as described here? |
jesscodez
suggested changes
Aug 4, 2017
README.md
Outdated
| @@ -75,7 +75,7 @@ kubectl get deployments --namespace=nginx-example | |||
| Finally, create an alias for the Ark client's Docker executable. (Make sure that your `KUBECONFIG` environment variable is pointing at the proper config first). This will save a lot of future typing: | |||
|
|
|||
| ``` | |||
| alias ark='docker run --rm -v $(dirname $KUBECONFIG):/kubeconfig -e KUBECONFIG=/kubeconfig/$(basename $KUBECONFIG) gcr.io/heptio-images/ark:latest' | |||
| alias ark='docker run --rm -u$(id -u) -v $(dirname $KUBECONFIG):/kubeconfig -e KUBECONFIG=/kubeconfig/$(basename $KUBECONFIG) gcr.io/heptio-images/ark:latest' | |||
There was a problem hiding this comment.
nit: could you put a space here for consistency (e.g. -u $(id -u))?
otherwise looks good!
There was a problem hiding this comment.
oh also one more thing: it's a bit of duplication, but do you mind also fixing the alias command here: https://github.com/heptio/ark/blob/master/docs/cli-reference/README.md
Since the ark container runs as a non-privileged user by default there are cases where it may not be able to read some user's config files if the permissions are more restrictive. Running the ark as the active user will make sure that the config file can be used in all cases. Signed-off-by: Carson Anderson <ca@carsonoid.net>
|
Updated with all requested changes |
|
Thanks @carsonoid! |
|
test this please |
jesscodez
approved these changes
Aug 4, 2017
dymurray
added a commit
to dymurray/velero
that referenced
this pull request
Nov 8, 2019
use experimental --skip-unchanged/--delete restic options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the ark container runs as a non-privileged user by default there are cases where it may not be able to read some user's config files if the permissions are more restrictive. Running the ark as the active user will make sure that the config file can be used in all cases.