-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify golangci.yaml file. Resolve found lint issues. #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
linter_setting
branch
3 times, most recently
from
March 21, 2023 08:36
4332dc2
to
a8a793f
Compare
blackpiglet
force-pushed
the
linter_setting
branch
2 times, most recently
from
March 21, 2023 08:59
648177a
to
ee39fea
Compare
blackpiglet
force-pushed
the
linter_setting
branch
2 times, most recently
from
March 21, 2023 12:18
ddbb654
to
267699b
Compare
Codecov Report
@@ Coverage Diff @@
## main #6008 +/- ##
==========================================
+ Coverage 41.26% 41.29% +0.03%
==========================================
Files 252 251 -1
Lines 23380 23369 -11
==========================================
+ Hits 9647 9650 +3
+ Misses 12974 12961 -13
+ Partials 759 758 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
blackpiglet
force-pushed
the
linter_setting
branch
from
March 24, 2023 03:19
267699b
to
bfbf69f
Compare
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
blackpiglet
force-pushed
the
linter_setting
branch
from
March 24, 2023 03:36
bfbf69f
to
4800a2d
Compare
qiuming-best
approved these changes
Mar 24, 2023
ywk253100
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Remove the enabled linters setting from
Makefile
. Move the enabled linters list intogolangci.yaml
.Enable more linters, including bodyclose, goheader, misspell, typecheck and unused.
Fix found issues found by linters.
Does your change fix a particular issue?
Fixes #6024
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.