Data mover wrong bsl after sync #6533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
added
kind/changelog-not-required
Lyndon-Li
force-pushed
the
data-mover-wrong-bsl-after-sync
branch
from
d6e1784 to
d804b14
Compare
Lyndon-Li
removed
the
kind/changelog-not-required
Lyndon-Li
force-pushed
the
data-mover-wrong-bsl-after-sync
branch
from
d804b14 to
6b8840b
Compare
Codecov Report
@@ Coverage Diff @@
## main #6533 +/- ##
==========================================
+ Coverage 60.28% 60.36% +0.07%
==========================================
Files 238 239 +1
Lines 25256 25498 +242
==========================================
+ Hits 15226 15391 +165
- Misses 8976 9036 +60
- Partials 1054 1071 +17
|
ywk253100
reviewed
Jul 25, 2023
| @@ -29,19 +29,22 @@ import ( | |||
|
|
|||
| velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1" | |||
| velerov2alpha1 "github.com/vmware-tanzu/velero/pkg/apis/velero/v2alpha1" | |||
| velerov1client "github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned/typed/velero/v1" | |||
There was a problem hiding this comment.
Let's use the controller runtime client instead as we are moving away from the generated clients
There was a problem hiding this comment.
Done the changes, thanks.
Lyndon-Li
force-pushed
the
data-mover-wrong-bsl-after-sync
branch
from
6b8840b to
ceac873
Compare
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Lyndon-Li
force-pushed
the
data-mover-wrong-bsl-after-sync
branch
from
ceac873 to
74bf03b
Compare
ywk253100
approved these changes
Jul 25, 2023
blackpiglet
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
StorageLocationis not reset to the latest one after backup sync, as a result, when deleting the PVB, the backup deletion controller cannot delete the repo snapshot from the correct backup storage location, so there will be data leak in the repoStorageLocationis retrieved from the DataUpload CR, while the value in DataUpload CR is not up to date if the BSL's name has changed in the new cluster, as a result, the data mover restore will failAs the fixes:
StorageLocationto the latest one during backup syncStorageLocationfrom the latest backup CR whoseStorageLocationhas been reset during backup syncFix #6534