Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 6647 #6751

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix issue 6647 #6751

merged 1 commit into from
Sep 6, 2023

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Sep 4, 2023

Fix issue #6647, add the --default-snapshot-move-data parameter to Velero install, so that users don't need to specify --snapshot-move-data per backup when they want to move snapshot data for all backups

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li marked this pull request as ready for review September 4, 2023 08:57
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #6751 (778feba) into main (831be07) will increase coverage by 0.01%.
Report is 14 commits behind head on main.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main    #6751      +/-   ##
==========================================
+ Coverage   60.33%   60.34%   +0.01%     
==========================================
  Files         242      242              
  Lines       25982    26009      +27     
==========================================
+ Hits        15675    15694      +19     
- Misses       9203     9208       +5     
- Partials     1104     1107       +3     
Files Changed Coverage Δ
pkg/install/deployment.go 90.00% <0.00%> (-2.83%) ⬇️
pkg/install/resources.go 76.82% <0.00%> (-0.95%) ⬇️
pkg/cmd/server/server.go 22.00% <66.66%> (+0.20%) ⬆️
pkg/controller/backup_controller.go 61.05% <75.00%> (+0.08%) ⬆️

... and 5 files with indirect coverage changes

@Lyndon-Li Lyndon-Li merged commit 8cb04d4 into vmware-tanzu:main Sep 6, 2023
@sseago
Copy link
Collaborator

sseago commented Sep 6, 2023

@Lyndon-Li Will this be cherry-picked to release-1.12 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants