exit server if not all Ark CRDs exist at startup #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
force-pushed
the
fail-fast-if-missing-crds
branch
from
16950a0 to
8d31472
Compare
nrb
reviewed
Jul 18, 2018
|
|
||
| // CustomResources returns a map of all custom resources within the Ark | ||
| // API group, keyed on Kind. | ||
| func CustomResources() map[string]typeInfo { |
There was a problem hiding this comment.
Would it make sense to re-use https://github.com/heptio/ark/blob/master/pkg/install/crd.go here? That way we'd have them defined in one place.
There was a problem hiding this comment.
I'd rather go the other way around (have pkg/install use the pkg/apis/ark/v1 func), but yeah good point, I'll update the install package.
There was a problem hiding this comment.
Yeah, that direction does make more sense. If we use one common source then we're less likely to miss requiring any new CRDs getting added.
skriss
force-pushed
the
fail-fast-if-missing-crds
branch
from
8d31472 to
ad0f94a
Compare
|
Working on adding a unit test for the server func. |
Signed-off-by: Steve Kriss <steve@heptio.com>
skriss
force-pushed
the
fail-fast-if-missing-crds
branch
from
ad0f94a to
1df9a8a
Compare
|
added unit. |
|
Manual testing looks good on this - if any CRD is missing, the server exits. If all are present, the server proceeds. |
|
I 👀 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss steve@heptio.com