Issue 6988: udmrepo use region specified in BSL when s3URL is empty #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Lyndon-Li
force-pushed
the
udmrepo-use-region-from-bsl
branch
from
92cf5b4 to
3d841dd
Compare
blackpiglet
approved these changes
Oct 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #6990 +/- ##
=======================================
Coverage 61.05% 61.05%
=======================================
Files 251 251
Lines 26845 26846 +1
=======================================
+ Hits 16389 16390 +1
Misses 9303 9303
Partials 1153 1153
|
reasonerjt
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6988, always get region from BSL if it is not empty