Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup log to show error string, not index #7805

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix backup log to show error string, not index #7805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b6c89c
Fix backup log to show error string, not index
piny940 May 18, 2024
059effc
Add change log 7805
piny940 May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/7805-piny940
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix backup log to show error string, not index
2 changes: 1 addition & 1 deletion pkg/controller/backup_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@
// Completed yet.
inProgressOperations, _, opsCompleted, opsFailed, errs := getBackupItemOperationProgress(backup.Backup, pluginManager, *backup.GetItemOperationsList())
if len(errs) > 0 {
for err := range errs {
for _, err := range errs {

Check warning on line 695 in pkg/controller/backup_controller.go

View check run for this annotation

Codecov / codecov/patch

pkg/controller/backup_controller.go#L695 

Added line #L695 was not covered by tests
backupLog.Error(err)
}
}
Expand Down
Loading