Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider unschedulable pods unrecoverable #7899

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Jun 17, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Don't consider "unschedulable" pods unrecoverable (for fast fail purposes), since pods will be briefly unschedulable while waiting for PV provisioning.

Does your change fix a particular issue?

Fixes #7898

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • [x ] Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Scott Seago <sseago@redhat.com>
@sseago sseago force-pushed the no-fast-fail-for-unschedulable branch from 130cfd2 to 9614ead Compare June 17, 2024 14:06
@sseago sseago marked this pull request as draft June 17, 2024 14:06
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.79%. Comparing base (89229d3) to head (9614ead).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7899      +/-   ##
==========================================
- Coverage   58.80%   58.79%   -0.01%     
==========================================
  Files         345      345              
  Lines       28771    28766       -5     
==========================================
- Hits        16919    16914       -5     
  Misses      10423    10423              
  Partials     1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseago sseago marked this pull request as ready for review June 24, 2024 23:37
@Lyndon-Li Lyndon-Li merged commit b0dc189 into vmware-tanzu:main Jun 25, 2024
69 checks passed
@Lyndon-Li
Copy link
Contributor

@sseago Please help to cherry-pick this PR to 1.14. Thanks.

clementnuss added a commit to clementnuss/k8s-gitops that referenced this pull request Aug 2, 2024
cf vmware-tanzu/velero#7898
contains the fix in vmware-tanzu/velero#7899

Signed-off-by: Clément Nussbaumer <clement@astutus.org>
@itayrin
Copy link

itayrin commented Aug 7, 2024

Hi, I just want to say that lately I was trying to integrate Velero 1.14.0 with our product and finding this specific commit made me downgrade to 13.2, since it's still not on any official version. This is an important fix, took me a few days to find the issue.

@sseago
Copy link
Collaborator Author

sseago commented Aug 7, 2024

@itayrin Yes, unfortunately we didn't discover this bug until 1.14.0 was out. Some storage providers provision volumes quickly enough that we don't hit it, so our pre-release testing didn't show this -- but other providers take a bit longer for volumes to come up, and for those providers this bug was hit all the time. 1.14.1 includes the fix, and we're hoping to release that around the end of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail early DM pod checks have false positives
4 participants