Skip PV patch step in Restore workflow for WaitForFirstConsumer VolumeBindingMode Pending state PVCs #7953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-pampattiwar
force-pushed
the
skip-pv-patch-wffc
branch
from
8c03287
to
04487e5
Compare
Closed
3 tasks
shubham-pampattiwar
changed the title
kaovilai
suggested changes
Jun 28, 2024
blackpiglet
reviewed
Jul 1, 2024
shubham-pampattiwar
force-pushed
the
skip-pv-patch-wffc
branch
2 times, most recently
from
30dc5a4
to
307a022
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7953 +/- ##
==========================================
+ Coverage 58.79% 58.81% +0.01%
==========================================
Files 345 345
Lines 28766 28805 +39
==========================================
+ Hits 16914 16941 +27
- Misses 10423 10434 +11
- Partials 1429 1430 +1 ☔ View full report in Codecov by Sentry. |
kaovilai
reviewed
Jul 2, 2024
…BindingMode Pending state PVCs Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog file Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> change log level and add more detailed comments Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> make update Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add return for sc get call if error Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
shubham-pampattiwar
force-pushed
the
skip-pv-patch-wffc
branch
from
307a022
to
ab09ef0
Compare
kaovilai
approved these changes
Jul 2, 2024
sseago
approved these changes
Jul 2, 2024
Lyndon-Li
approved these changes
Jul 11, 2024
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Jul 12, 2024
…BindingMode Pending state PVCs (vmware-tanzu#7953) add changelog file change log level and add more detailed comments make update add return for sc get call if error Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> (cherry picked from commit 3bd8a7d)
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Jul 12, 2024
…BindingMode Pending state PVCs (vmware-tanzu#7953) add changelog file change log level and add more detailed comments make update add return for sc get call if error Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> (cherry picked from commit 3bd8a7d) update changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Jul 12, 2024
…BindingMode Pending state PVCs (vmware-tanzu#7953) add changelog file change log level and add more detailed comments make update add return for sc get call if error Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> (cherry picked from commit 3bd8a7d) update changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
Lyndon-Li
added a commit
that referenced
this pull request
Jul 15, 2024
…1.14 Skip PV patch step in Restore workflow for WaitForFirstConsumer VolumeBindingMode Pending state PVCs (#7953)
dzaninovic
pushed a commit
to catalogicsoftware/velero
that referenced
this pull request
Sep 4, 2024
…BindingMode Pending state PVCs (vmware-tanzu#7953) add changelog file change log level and add more detailed comments make update add return for sc get call if error Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> (cherry picked from commit 3bd8a7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7866
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.