Configurable Kopia Maintenance Interval

[kaovilai]

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Configurable Kopia Maintenance Interval. repo-maintenance-job-configmap adds an option for fullMaintenanceInterval where fastGC (12 hours), and eagerGC (6 hours).
This configmap is loaded in assembleRepoParam that returns RepoParam which now contains the maintenance interval referenced by several repository functions.
The manager functions then call provider functions which read repoParam.FullMaintenanceInterval and add it to repoOption.
Repooption is then passed to repoService, in this case kopiaRepoService.Init
kopiaRepoService.Init calls writeInitParameters which finally set kopia p.FullCycle.Interval

Does your change fix a particular issue?

Fixes #8364

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 59.37%. Comparing base (3eaa739) to head (7d9b489).
Report is 58 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/repository/udmrepo/kopialib/lib_repo.go	7.69%	9 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8581      +/-   ##
==========================================
+ Coverage   59.18%   59.37%   +0.18%     
==========================================
  Files         370      370              
  Lines       39595    40004     +409     
==========================================
+ Hits        23434    23752     +318     
- Misses      14679    14756      +77     
- Partials     1482     1496      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaovilai]

Preview: https://velero-git-configkopiamaintinterval-kaovilais-projects.vercel.app/docs/main/repository-maintenance#full-maintenance-interval-customization

[kaovilai]

found https://velero.io/docs/main/backup-repository-configuration/ so will add info there and link from maintenance config page.

[kaovilai]

Currently double checking the flow of backup-repository-configmap from specifying a configmap to reading to storing into a repoOption.StorageOptions[key]

velero/pkg/controller/backup_repository_controller.go

Lines 404 to 405 in b4247c9

	func getBackupRepositoryConfig(ctx context.Context, ctrlClient client.Client, configName, namespace, repoName, repoType string, log logrus.FieldLogger) (map[string]string, error) {
	if configName == "" {

is called [here](

velero/pkg/controller/backup_repository_controller.go

Line 249 in 92390e9

config, err := getBackupRepositoryConfig(ctx, r, r.backupRepoConfig, r.namespace, req.Name, req.Spec.RepositoryType, log)

which defines config := map[string]string with all the values set by user.
This map of string is then set to backupRepository.spec.RepositoryConfig and patched to cluster CR in following

velero/pkg/controller/backup_repository_controller.go

Line 233 in 92390e9

func (r *BackupRepoReconciler) initializeRepo(ctx context.Context, req *velerov1api.BackupRepository, log logrus.FieldLogger) error {

This function is only called when backupRepo is in newly created as part of a backuprepo Reconcile()

This is used by

velero/pkg/repository/provider/unified_repo.go

Line 394 in 69b456a

func (urp *unifiedRepoProvider) GetStoreOptions(param interface{}) (map[string]string, error) {

via

velero/pkg/repository/provider/unified_repo.go

Line 400 in 69b456a

storeVar, err := funcTable.getStorageVariables(repoParam.BackupLocation, urp.repoBackend, repoParam.BackupRepo.Spec.VolumeNamespace, repoParam.BackupRepo.Spec.RepositoryConfig)

However, getStorageVariables() do not pass all the options from backupRepoConfig back.

velero/pkg/repository/provider/unified_repo.go

Lines 571 to 575 in b4247c9

	if backupRepoConfig != nil {
	if v, found := backupRepoConfig[udmrepo.StoreOptionCacheLimit]; found {
	result[udmrepo.StoreOptionCacheLimit] = v
	}
	}

So either make getStorageVariables() pass everything, or make it add the maintenance interval to one of the things it adds.

[kaovilai]

@blackpiglet @Lyndon-Li any opinions on making getStorageVariables return everything from backupRepoConfig?

So either make getStorageVariables() pass everything, or make it add the maintenance interval to one of the things it adds.