Add the design of cleaning artifacts generated during CSI B/R #8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
kind/changelog-not-required
blackpiglet
force-pushed
the
7979_design
branch
from
fe4e8d2 to
43bbfa8
Compare
blackpiglet
force-pushed
the
7979_design
branch
from
43bbfa8 to
c369e45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8676 +/- ##
=======================================
Coverage 59.39% 59.39%
=======================================
Files 370 370
Lines 39988 39988
=======================================
Hits 23752 23752
Misses 14744 14744
Partials 1492 1492 ☔ View full report in Codecov by Sentry. |
Lyndon-Li
reviewed
Feb 11, 2025
| if (vsc.Status != nil && boolptr.IsSetToTrue(vsc.Status.ReadyToUse)) && | ||
| (vs.Status != nil && boolptr.IsSetToTrue(vs.Status.ReadyToUse)) { | ||
| // VS and VSC are ready. Delete them to make sure they will not cause conflict for the next restore. | ||
| if err := p.crClient.Delete(context.TODO(), vs); err != nil { |
There was a problem hiding this comment.
It doesn't look reasonable to do these deletion in a Progress call
There was a problem hiding this comment.
We can move the deletion logic into the restore finalization controller.
blackpiglet
force-pushed
the
7979_design
branch
2 times, most recently
from
593495e to
0b0a727
Compare
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
blackpiglet
force-pushed
the
7979_design
branch
from
0b0a727 to
b72f660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.