Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add the vCenter UUID annotation on the VM #579

Merged
merged 1 commit into from
Jul 2, 2024
Merged

🌱 Add the vCenter UUID annotation on the VM #579

merged 1 commit into from
Jul 2, 2024

Conversation

aruneshpa
Copy link
Contributor

What does this PR do, and why is it needed?

This change adds the vCenter annotation on the VirtualMachine custom resource. Among other things, this annotation can be used to determine whether a VM is being restored on the same vCenter where it was originally created.

Please add a release note if necessary:

Add vCenter UUID annotation on the VM

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 12, 2024
@aruneshpa aruneshpa force-pushed the topic/parunesh/add-vc-uuid-annotation-on-vc branch from 60e9626 to 68ebc10 Compare June 12, 2024 23:21
@aruneshpa
Add the vCenter UUID annotation to VM
5ee84e3 
This change adds the vCenter annotation on the VirtualMachine custom
resource.  Among other things, this annotation can be used to
determine whether a VM is being restored on the same vCenter where it
was originally created.
@aruneshpa aruneshpa force-pushed the topic/parunesh/add-vc-uuid-annotation-on-vc branch from 68ebc10 to 5ee84e3 Compare July 2, 2024 18:38
akutz
akutz requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @aruneshpa !

akutz
akutz approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I selected "request changes" on accident. Approved :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 97% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/capability 89% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 71% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine 87% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 75% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 83% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 80% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/volume 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/builder 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 71% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 82% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 74% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 68% ❌
github.com/vmware-tanzu/vm-operator/pkg/record 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/topology 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 87% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 81% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/ptr 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 99% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 68% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 85% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation 92% ✔
Summary 81% (8202 / 10090) ➖

Minimum allowed line rate is 79%

@aruneshpa aruneshpa merged commit e711e8d into vmware-tanzu:main Jul 2, 2024
11 checks passed
@aruneshpa aruneshpa deleted the topic/parunesh/add-vc-uuid-annotation-on-vc branch July 2, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akutz akutz akutz approved these changes

@dilyar85 dilyar85 dilyar85 approved these changes

Assignees
No one assigned
Labels
cla-not-required size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aruneshpa @akutz @dilyar85 @vmwclabot