Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Include both vm_name and interface_name in VPCAttachmentRef #624

Merged
merged 1 commit into from
Jul 24, 2024
Merged

🌱 Include both vm_name and interface_name in VPCAttachmentRef #624

merged 1 commit into from
Jul 24, 2024

Conversation

zyiyi11
Copy link
Contributor

@zyiyi11 zyiyi11 commented Jul 11, 2024 •
edited
Loading

What does this PR do, and why is it needed?
To accommodate NSX Operator's newly introduced ExternalAddressBinding CR, which is to associate an External IP to a VM that will eventually associate an external IP to subnet port. Their ask is for VM Operator to provide interface name in VPCAttachmentRef.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes N/A

Are there any special notes for your reviewer:
This change needs to be merge around the same time NSX Operator merges their change.

Please add a release note if necessary:

NONE

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 11, 2024
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 97% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/capability 89% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 71% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 75% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset 68% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 83% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 80% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/volume 87% ➖
github.com/vmware-tanzu/vm-operator/pkg/builder 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/client 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 71% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 80% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 74% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/sysprep 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 82% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 74% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 68% ❌
github.com/vmware-tanzu/vm-operator/pkg/record 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/topology 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 87% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 81% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/ptr 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 99% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 68% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 86% ➖
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 87% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation 92% ✔
Summary 82% (8505 / 10412) ➖

Minimum allowed line rate is 79%

gran-vmv added a commit to gran-vmv/nsx-operator that referenced this pull request Jul 12, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format
c871f59 
Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
@gran-vmv gran-vmv mentioned this pull request Jul 12, 2024
Merged
gran-vmv added a commit to gran-vmv/nsx-operator that referenced this pull request Jul 17, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format
81365fb 
Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
gran-vmv added a commit to gran-vmv/nsx-operator that referenced this pull request Jul 22, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format
5e2fd30 
Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
gran-vmv added a commit to gran-vmv/nsx-operator that referenced this pull request Jul 23, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format
1d5458b 
Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
gran-vmv added a commit to vmware-tanzu/nsx-operator that referenced this pull request Jul 24, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format (#635)
6b05d60 
Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
gran-vmv added a commit to gran-vmv/nsx-operator that referenced this pull request Jul 24, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format (vmware-tan…
baf463b 
…zu#635)

Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
@gran-vmv gran-vmv mentioned this pull request Jul 24, 2024
Merged
@zyiyi11 zyiyi11 merged commit 75ac10d into vmware-tanzu:main Jul 24, 2024
13 checks passed
gran-vmv added a commit to vmware-tanzu/nsx-operator that referenced this pull request Jul 24, 2024
@gran-vmv
[VPC][SubnetPort] Update attachment_ref annotation format (#635) (#647)
57e668b 
Follow the change in vmware-tanzu/vm-operator#624

Signed-off-by: gran <gran@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanv bryanv bryanv approved these changes

Assignees
No one assigned
Labels
cla-not-required size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyiyi11 @bryanv @vmwclabot