Replace version/version.go with internal/version/version.go #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On case-insensitive filesystems (which includes default macOS installations), it is not possible to have a "version" directory and a "VERSION" file in the same parent directory, and the repo cannot be cloned succesfully. To resolve this, we replace version/version.go with internal/version/version.go. Additionally, we stop using "0.0.1" as the version string, as it is not consistent with the contents of the VERSION file, nor with the Docker tag. Instead, we use the VERSION file as the one source of truth. We also add a "--version" command-line flag to the operator binary, which displays the version and exits. Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
remove-version/version.go
branch
from
8bf7a70
to
435bb91
Compare
|
@ksamoray not sure what to do with https://github.com/vmware/antrea-operator-for-kubernetes/tree/main/olm-catalog |
It's an old leftover which isn't in use.I'll delete it. |
salv-orlando
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On case-insensitive filesystems (which includes default macOS installations), it is not possible to have a "version" directory and a "VERSION" file in the same parent directory, and the repo cannot be cloned succesfully. To resolve this, we replace version/version.go with internal/version/version.go.
Additionally, we stop using "0.0.1" as the version string, as it is not consistent with the contents of the VERSION file, nor with the Docker tag. Instead, we use the VERSION file as the one source of truth. We also add a "--version" command-line flag to the operator binary, which displays the version and exits.