Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to openshift platform in Makefile #96

Merged

Conversation

antoninbas
Copy link
Member

To avoid flip-flopping between kubernetes and openshift in generated manifests. Openshift is also the main use-case at the moment for this operator.

We also add a new Github workflow to validate manifest generation for each PR.

See also #94 for a related discussion.

To avoid flip-flopping between kubernetes and openshift in generated
manifests. Openshift is also the main use-case at the moment for this
operator.

We also add a new Github workflow to validate manifest generation for
each PR.

See also vmware#94 for a related discussion.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Copy link
Contributor

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit aa911f4 into vmware:main Dec 18, 2023
5 checks passed
@antoninbas antoninbas deleted the default-to-openshift-platformin-makefile branch December 18, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants