[VCDA-2578, VCDA-2108, VCDA-2262] Cluster share fix and system user cluster sharing

[ltimothy7]

Signed-off-by: ltimothy ltimothy@vmware.com

To help us process your pull request efficiently, please include:

• (Required) Detailed description of changes include tests and
  documentation. If the pull request contains multiple commits with
  detailed messages, refer to those instead
  Tested sharing, unsharing, and sharing list for native and TKG system and non-system users

• (Optional) Names of reviewers using @ sign + name

---

This change is 

[Anirudh9794]

minor question.

Reviewed 19 of 19 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ltimothy7)

---

container_service_extension/rde/models/common_models.py, line 144 at r1 (raw file):

    owner: Optional[Owner] = None
    org: Optional[Org] = None
    metadataSummary: Optional[list] = None

Are we not ignoring metadataSummary ?
Is DefEntity(**entity_dict) raising an exception?

[vmwclabot]

@ltimothy7, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 147b6ed must be signed by ltimothy@vmware.com

[ltimothy7]

---

container_service_extension/rde/models/common_models.py, line 144 at r1 (raw file):

Previously, Anirudh9794 wrote…

Are we not ignoring metadataSummary ?
Is DefEntity(**entity_dict) raising an exception?

Thanks Aniruddha, This is no longer needed, it was raising an exception

[Anirudh9794]

---

container_service_extension/common/utils/pyvcloud_utils.py, line 663 at r2 (raw file):

            client=client,
            resource=org_obj)
        if org.get_vdc(vdc_name) is not None:

This function can possibly become really costly.There were customers who had thousands of orgs and thousands of vdcs in each org. I think it is better to use typed query like
https://github.com/vmware/pyvcloud/blob/master/pyvcloud/vcd/client.py#L1599
instead of iterating over orgs

[vmwclabot]

@ltimothy7, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 147b6ed must be signed by ltimothy@vmware.com

[vmwclabot]

@ltimothy7, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 147b6ed must be signed by ltimothy@vmware.com

[sahithi]

(few comments)
Tim, I could not review the correctness of the logical workflow as I don't remember the full context. I suggest demonstrating this piece in our next demo as a refresher to all of us.

Reviewable status: 10 of 19 files reviewed, 4 unresolved discussions (waiting on @Anirudh9794 and @ltimothy7)

---

container_service_extension/common/constants/shared_constants.py, line 84 at r4 (raw file):

# System org constants
SYSTEM_ORG_NAME = 'system'

Don't we already have System constant declared somewhere?

---

container_service_extension/rde/models/common_models.py, line 190 at r4 (raw file):

@dataclass()
class ClusterAclEntry:

I suggest using dataclass_json annotation to enable snake case fields in the python code.
This will enable easy conversions between JSON payloads.

Please add a TODO if you want to take this task up later.

[vmwclabot]

@ltimothy7, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 147b6ed must be signed by ltimothy@vmware.com

[ltimothy7]

Reviewable status: 10 of 19 files reviewed, 4 unresolved discussions (waiting on @Anirudh9794 and @sahithi)

---

container_service_extension/common/constants/shared_constants.py, line 84 at r4 (raw file):

Previously, sahithi (Sahithi Ayloo) wrote…

Don't we already have System constant declared somewhere?

Yes, I needed to move it to shared_constants so that de_cluster_tkg could use the constant

---

container_service_extension/common/utils/pyvcloud_utils.py, line 663 at r2 (raw file):

Previously, Anirudh9794 wrote…

This function can possibly become really costly.There were customers who had thousands of orgs and thousands of vdcs in each org. I think it is better to use typed query like
https://github.com/vmware/pyvcloud/blob/master/pyvcloud/vcd/client.py#L1599
instead of iterating over orgs

Done. Thanks Aniruddha

---

container_service_extension/rde/models/common_models.py, line 190 at r4 (raw file):

Previously, sahithi (Sahithi Ayloo) wrote…

I suggest using dataclass_json annotation to enable snake case fields in the python code.
This will enable easy conversions between JSON payloads.

Please add a TODO if you want to take this task up later.

Done. Thank you, this is now a dataclass_json