Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable nfs test for ctots #1369

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

ltimothy7
Copy link
Contributor

@ltimothy7 ltimothy7 commented Jul 6, 2022

Signed-off-by: ltimothy7 66969084+ltimothy7@users.noreply.github.com

To help us process your pull request efficiently, please include:

  • (Required) Short description of changes in the PR topic line

  • (Required) Detailed description of changes include tests and
    documentation. If the pull request contains multiple commits with
    detailed messages, refer to those instead

  • (Optional) Names of reviewers using @ sign + name


This change is Reviewable

Signed-off-by: ltimothy7 <66969084+ltimothy7@users.noreply.github.com>
@vmwclabot
Copy link
Member

@ltimothy7, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also have to block comment the following fixture setting in case?

@pytest.fixture
def cluster_delete_nfs_param(request):
....
.....

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ltimothy7)

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ltimothy7)

@ltimothy7 ltimothy7 merged commit 28745ed into vmware:master Jul 7, 2022
@ltimothy7 ltimothy7 deleted the disable_nfs_test branch July 19, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants