Improve handling of string IEs #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antoninbas
commented
Sep 29, 2023
antoninbas
commented
- Use the copy built-in to copy string bytes to buffer, instead of copying bytes one-by-one with a for loop. This is more efficient (confirmed with new Benchmark functions) and more correct (in case the string includes UTF-8 characters which use more than 1 byte).
- Increase max string length from 65,534 to 65,535.
|
New benchmark results: Without the use of |
* Use the copy built-in to copy string bytes to buffer, instead of copying bytes one-by-one with a for loop. This is more efficient (confirmed with new Benchmark functions) and more correct (in case the string includes UTF-8 characters which use more than 1 byte). * Increase max string length from 65,534 to 65,535. Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
improve-handling-of-strings
branch
from
5957a81
to
631df37
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 73.54% 73.44% -0.11%
==========================================
Files 18 18
Lines 2786 2790 +4
==========================================
Hits 2049 2049
- Misses 572 574 +2
- Partials 165 167 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dreamtalen
pushed a commit
to dreamtalen/go-ipfix
that referenced
this pull request
Oct 2, 2023
* Use the copy built-in to copy string bytes to buffer, instead of copying bytes one-by-one with a for loop. This is more efficient (confirmed with new Benchmark functions) and more correct (in case the string includes UTF-8 characters which use more than 1 byte). * Increase max string length from 65,534 to 65,535 (as per the IPFIX RFC 7011). Signed-off-by: Antonin Bas <abas@vmware.com>
dreamtalen
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Use the copy built-in to copy string bytes to buffer, instead of copying bytes one-by-one with a for loop. This is more efficient (confirmed with new Benchmark functions) and more correct (in case the string includes UTF-8 characters which use more than 1 byte). * Increase max string length from 65,534 to 65,535 (as per the IPFIX RFC 7011). Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.