Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load balancer service monitor CRUD to govcd #196

Merged
merged 16 commits into from
Jun 13, 2019
Merged

Conversation

Didainius
Copy link
Collaborator

Ref https://github.com/terraform-providers/terraform-provider-vcd/issues/223

This is first govcd PR to start supporting edge gateway load balancers which adds ability to perform CRUD operations for service monitors.
More about service monitors: https://docs.vmware.com/en/vCloud-Director/9.0/com.vmware.vcloud.tenantportal.doc/GUID-DE3EDF95-1A8E-4D2F-B7B1-1254E9420868.html

@Didainius Didainius requested review from vbauzys and lvirbalas June 5, 2019 09:33
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find CHANGELOG.md addition, but maybe it's in a different PR?

Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and requests while I run the tests

govcd/api.go Outdated Show resolved Hide resolved
govcd/api.go Outdated Show resolved Hide resolved
govcd/api_vcd_test.go Outdated Show resolved Hide resolved
govcd/edgegateway.go Outdated Show resolved Hide resolved
govcd/edgegateway.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor_test.go Outdated Show resolved Hide resolved
types/v56/types.go Outdated Show resolved Hide resolved
types/v56/types.go Outdated Show resolved Hide resolved
types/v56/types.go Show resolved Hide resolved
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code and I added some comments to consider.

govcd/api.go Outdated Show resolved Hide resolved
govcd/api.go Outdated Show resolved Hide resolved
govcd/edgegateway.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor.go Outdated Show resolved Hide resolved
govcd/edgegateway_lb_service_monitor_test.go Outdated Show resolved Hide resolved
govcd/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius Didainius merged commit 07823be into vmware:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants