Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functions for getting and updating Org vDC #206

Merged
merged 12 commits into from
Jul 1, 2019
Merged

New functions for getting and updating Org vDC #206

merged 12 commits into from
Jul 1, 2019

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Jun 21, 2019

Ref: terraform-providers/terraform-provider-vcd#237

Added functions for refreshing, getting and update Org vDC. Will be used in terraform.

Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review

govcd/org.go Outdated Show resolved Hide resolved
govcd/org.go Outdated Show resolved Hide resolved
govcd/org.go Outdated Show resolved Hide resolved
govcd/org_test.go Outdated Show resolved Hide resolved
govcd/org_test.go Outdated Show resolved Hide resolved
types/v56/types.go Outdated Show resolved Hide resolved
govcd/org.go Outdated Show resolved Hide resolved
vbauzys added 2 commits June 27, 2019 16:39
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
types/v56/types.go Outdated Show resolved Hide resolved
vbauzys added 3 commits June 28, 2019 10:03
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
govcd/org_test.go Outdated Show resolved Hide resolved
vbauzys added 3 commits July 1, 2019 11:52
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbauzys added 3 commits July 1, 2019 12:21
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass.
The only optional thing that error should always be the last returned value as per Go idioms.
But I'm not insisting it now as this is just an internal test helper.

check.Assert(adminVdc.AdminVdc.Name, Equals, TestRefreshOrgVdc)
}

func setupVDc(vcd *TestVCD, check *C) (AdminOrg, error, *types.VdcConfiguration) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func setupVDc(vcd *TestVCD, check *C) (AdminOrg, error, *types.VdcConfiguration) {
func setupVDc(vcd *TestVCD, check *C) (AdminOrg, *types.VdcConfiguration, error) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@vbauzys vbauzys merged commit 7f2e050 into vmware:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants