Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load balancer application rule CRUD #212

Merged
merged 21 commits into from
Jul 11, 2019
Merged

Add load balancer application rule CRUD #212

merged 21 commits into from
Jul 11, 2019

Conversation

Didainius
Copy link
Collaborator

Continuing work on https://github.com/terraform-providers/terraform-provider-vcd/issues/223

This one introduces Load Balancer Application Rule.

@Didainius Didainius self-assigned this Jul 8, 2019
vbauzys
vbauzys approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lvirbalas
lvirbalas requested changes Jul 10, 2019
View reviewed changes
govcd/lbapprule.go Outdated Show resolved Hide resolved
govcd/lbapprule_test.go Show resolved Hide resolved
lvirbalas
lvirbalas approved these changes Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment for myself: look forward for a separate PR which will adjust "ID" -> "Id" in function names.

dataclouder
dataclouder approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius Didainius merged commit 20df7a4 into vmware:master Jul 11, 2019
@Didainius Didainius deleted the lb44 branch July 11, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbauzys vbauzys vbauzys approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@Didainius Didainius

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Didainius @lvirbalas @dataclouder @vbauzys @vmwclabot