Add guest properties support for vm and vapp
#235
Conversation
Didainius
requested review from
vbauzys,
lvirbalas and
dataclouder
and removed request for
vbauzys and
lvirbalas
Yes. The idea is that whatever is set in There is no mechanism to set "one by one" and even if there was - such method is way quicker than setting 100 properties in "one by one" fashion. |
CHANGELOG.md
Outdated
| @@ -22,6 +22,8 @@ | |||
| * Added methods `AdminOrg.GetVDCByName` and related `GetVDCById`, `GetVDCByNameOrId` | |||
| * Added methods `AdminOrg.GetAdminVDCByName` and related `GetAdminVDCById`, `GetAdminVDCByNameOrId` | |||
| * Added methods `Catalog.Refresh` and `AdminCatalog.Refresh` | |||
| * Added methods `vm.SetGuestProperties` and `vm.GetGuestProperties` [#235](https://github.com/vmware/go-vcloud-director/pull/235) | |||
| * Added methods `vapp.SetGuestProperties` and `vapp.GetGuestProperties` [#235](https://github.com/vmware/go-vcloud-director/pull/235) | |||
There was a problem hiding this comment.
Structure has been renamed, but change log entry left old.
There was a problem hiding this comment.
I knew I had to miss it somewhere while renaming. Fixed.
| // SetProductSectionList sets product section for a vApp | ||
| // | ||
| // The slice of properties "ProductSectionList.ProductSection.Property" is not necessarily ordered or returned as set before | ||
| func (vapp *VApp) SetProductSectionList(productSection *types.ProductSectionList) (*types.ProductSectionList, error) { |
There was a problem hiding this comment.
I would add a sentence - a hint - that this product section represents guest properties in all comments of the four public functions.
There was a problem hiding this comment.
Typo in "maniapulate", sounds funny though :D
Both VMs and vApps allow to set guest properties which are useful for configuration (when guests support it).
This PR adds
SetGuestPropertiesSetProductSectionListandGetGuestPropertiesGetProductSectionListforvmandvappobjects which allow to manipulate guest properties