Add support for NAT rules using proxied NSX-V API #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
reviewed
Sep 11, 2019
lvirbalas
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Very nice. Before merge, please confirm two functional aspects:
- That NAT rule(s) created by this method may be updated via H5 UI and vice versa (that these operations don't collide anymore).
- That it will be possible from Terraform side to create a DNAT rule on an external network with an org admin connection (with current DNAT rule that's not possible though in UI it is).
Yes, they can be updated. II have manually tested it using terraform resources and "read" capabilities, which hint updates.
Yes, it must be so. It does not try to access any other resources outside of edge gateway. If the edge gateway has an external network attached - it uses it. |
vbauzys
suggested changes
Sep 17, 2019
vbauzys
reviewed
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for methods to allow configuring Edge Gateway NAT rules using proxied NSX-V API.
It introduces a few new methods:
CreateNsxvNatRule,UpdateNsxvNatRule,GetNsxvNatRuleByIdandDeleteNsxvNatRuleById.The creation of above mentioned NAT rules requires to specify a vNic (network interface on edge gateway). To easen lookup of vNic and replicating similar behaviour as vCD UI two more methods are added:
GetVnicIndexByNetworkNameAndTypeandGetNetworkNameAndTypeByVnicIndex. They allow to convert between vNic index number and network type and network name.It should also be compatible with subinterfaces when we implement them in other places: https://github.com/terraform-providers/terraform-provider-vcd/issues/321