Add CRUD support for IP set management #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
approved these changes
Nov 27, 2019
| "github.com/vmware/go-vcloud-director/v2/util" | ||
| ) | ||
|
|
||
| func (vdc *Vdc) CreateNsxvIpSet(ipSetConfig *types.EdgeIpSet) (*types.EdgeIpSet, error) { |
There was a problem hiding this comment.
Would like an introduction-like comment about IP sets and into which object they are being created.
There was a problem hiding this comment.
Indeed. I forgot to add a doc at all. Fixed.
vbauzys
suggested changes
Nov 28, 2019
vbauzys
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions to handle IP sets:
CreateNsxvIpSet,UpdateNsxvIpSet,GetNsxvIpSetByName,GetNsxvIpSetById,GetNsxvIpSetByNameOrId,GetAllNsxvIpSets,DeleteNsxvIpSetById,DeleteNsxvIpSetByNameAdditional cleanups
typesfile into multiple files as it is becoming huge.