Change bool -> *bool in types.GuestCustomizationSection #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbauzys
reviewed
Mar 2, 2020
vbauzys
suggested changes
Mar 2, 2020
lvirbalas
approved these changes
Mar 2, 2020
govcd/vm.go
Outdated
| @@ -445,6 +445,9 @@ func (vm *VM) BlockWhileGuestCustomizationStatus(unwantedStatus string, timeOutA | |||
| } | |||
| } | |||
|
|
|||
| // Customize function allows to set computername, apply customization script and enable or disble the changeSid option | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| // Customize function allows to set computername, apply customization script and enable or disble the changeSid option | |
| // Customize function allows to set ComputerName, apply customization script and enable or disable the changeSid option |
vbauzys
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve https://github.com/terraform-providers/terraform-provider-vcd/issues/303 and other problems it is better to have *bool instead of bool types (to distinguish between 0 and nil values).
This PR aims to solve just that and also deprecates some functions which are not technically correct.
Test suite passed on 9.5