Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deleteVapp() testing function #297

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Improve deleteVapp() testing function #297

merged 2 commits into from
Mar 31, 2020

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Mar 31, 2020 •
edited
Loading

In some cases vApp deletion in tests could stumble on still running task of vApp deletion and fail like that:

....
# 2 removeLeftoverEntries: [INFO] Attempting cleanup of network 'TestCreateOrgVdcNetworkDhcp' instantiated by TestCreateOrgVdcNetworkDhcp
removeLeftoverEntries: [ERROR] Error deleting network 'TestCreateOrgVdcNetworkDhcp': error deleting network [phase 1] TestCreateOrgVdcNetworkDhcp

This PR adds network detachment and deletion task tracking output. It also improves error reporting in RemoveOrgVdcNetworkIfExists function

So far I have tested

  • go test -tags functional -check.vv -timeout 0 -check.f Test_VMGetDhcpAddress 7+ times.
  • Full suite run on vCD 10.0.0.1

@Didainius Didainius self-assigned this Mar 31, 2020
dataclouder
dataclouder approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius Didainius merged commit 9dbe26f into vmware:master Mar 31, 2020
@Didainius Didainius deleted the fix-vapp-deletion-task-tracking branch March 31, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbauzys vbauzys vbauzys approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@Didainius Didainius

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Didainius @lvirbalas @dataclouder @vbauzys @vmwclabot